Decomp LoadScriptVariableValue #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| VARTYPE_DUMMY_PADDING = 256 | ||
| }; | ||
|
|
||
| enum script_var_id { |
Collaborator
There was a problem hiding this comment.
Might as well bring over the whole enum since it is known.
Collaborator
There was a problem hiding this comment.
I don't see the rest of this enum yet. Did something go wrong with the commits?
slaw-22
force-pushed
the
LoadScriptVariableValue
branch
from
742e220 to
bb37701
Compare
Collaborator
|
I ran into a function that uses |
AnonymousRandomPerson
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used script_var_type, script_var_def and special_episode_type from pmdsky debug. Please let me know if this is not Ok!
I've also used the relevant parts of script_var_id from pmdsky debug, but not all of it. I can bring the whole enum in if preferred.