Battle HP Bar and related code #336
Conversation
PikalaxALT
changed the title
| u8 script; | ||
| void *unk4; | ||
| void *unk8; | ||
| struct { |
There was a problem hiding this comment.
using pokeplatinum/retsam to try and match stuff, they did something similar on their end. didn't help the three affected functions tho.
| void ov12_0226498C(BattleHpBar *hpBar, u32 num, u32 flag) { | ||
| GF_ASSERT(hpBar->unk4 != NULL); | ||
| if (hpBar->type == HP_BAR_TYPE_SAFARI) { | ||
| flag &= 0xC00; |
There was a problem hiding this comment.
would prefer some consts here even if theyre all unown, ie #def HP_BAR_FLAG_4 (1 << 4) type things
src/battle/battle_hp_bar.c
Outdated
|
|
||
| narc = NARC_New(NARC_a_0_0_8, HEAP_ID_BATTLE); | ||
|
|
||
| renderer = ov12_0223A8E4(hpBar->bsys); |
There was a problem hiding this comment.
ov12_0223A8E4 -> BattleSystem_GetSpriteRenderer
src/battle/battle_hp_bar.c
Outdated
| narc = NARC_New(NARC_a_0_0_8, HEAP_ID_BATTLE); | ||
|
|
||
| renderer = ov12_0223A8E4(hpBar->bsys); | ||
| gfxHandler = ov12_0223A8EC(hpBar->bsys); |
There was a problem hiding this comment.
ov12_0223A8EC -> BattleSystem_GetGfxHandler
src/battle/battle_hp_bar.c
Outdated
| Sprite_SetPositionXY(hpBar->unk4->sprite, r4->x + x, r4->y + y); | ||
| if (hpBar->unk8 != NULL) { | ||
| Sprite_SetPositionXY(hpBar->unk8->sprite, | ||
| r4->x + x - ov12_0226D368[hpBar->type], |
There was a problem hiding this comment.
ov12_0226D368 -> sHpBarXOffsets
There was a problem hiding this comment.
or sHpBoxXOffsets, etc, whatever you want
| AddTextPrinterParameterizedWithColorAndSpacing(&window, 0, string, 0, 0, TEXT_SPEED_NOTRANSFER, MAKE_TEXT_COLOR(14, 2, 15), 0, 0, NULL); | ||
| srcBuf = window.pixelBuffer; | ||
|
|
||
| { |
There was a problem hiding this comment.
brackets required to match?
| #ifdef NONMATCHING | ||
| static void ov12_02264F44(BattleHpBar *hpBar, int x, int y) { | ||
| const UnkTemplate_0200D748 *r4; | ||
| const UnkTemplate_0200D748 *tmplate; |
There was a problem hiding this comment.
tmplate -> template
2 participants
No description provided.