Document Gym scripts #793
Document Gym scripts #793
Conversation
asm/macros/scrcmd.inc
Outdated
| .endm | ||
|
|
||
| .macro ScrCmd_176 arg0 | ||
| .macro SunnyshoreGymButton arg0 |
There was a problem hiding this comment.
polish: PressSunyshoreGymButton (note that it's Sunyshore, not Sunnyshore).
asm/macros/scrcmd.inc
Outdated
| .endm | ||
|
|
||
| .macro ScrCmd_2CA | ||
| .macro EternaGymAdvanceClockState |
There was a problem hiding this comment.
suggestion: AdvanceEternaGymClock
| "movement_type": "MOVEMENT_TYPE_LOOK_NORTH", | ||
| "trainer_type": "TRAINER_TYPE_NONE", | ||
| "flag": "FLAG_UNK_0x01B2", | ||
| "flag": "FLAG_CANALAVE_RIVAL", |
There was a problem hiding this comment.
thought: Should flags have some verbiage attached to them? e.g., does this flag designate that you've spoken to your rival? Fought your rival? etc.
There was a problem hiding this comment.
I wasn't entirely sure how to document the "flag" fields, because "flag" seems to be an active-low indicator for the object's presence. To me, that means that this field would make more sense to rename as "hidden", rather than append _HIDDEN to every one of these flag variables. I'm not sure if that would have any further reaching implications though.
There was a problem hiding this comment.
Yes, the flag being set to non-0 means that the object should be hidden. What if we just use a verbiage of FLAG_HIDE_X?
| "_comment": "this is right above the kid at the bottom of the stairs", | ||
| "script": 3, |
There was a problem hiding this comment.
suggestion: I don't think that this comment adds much value long-term; the goal is for events to be edited in some kind of GUI, anyways.
There was a problem hiding this comment.
Whoops, that was supposed to be a debug/note thing, forgot to delete it before committing.
|
|
||
| AcuityCavern_CheckShouldUxieBeRemoved: | ||
| GoToIfSet FLAG_UNK_0x008E, AcuityCavern_RemoveUxie | ||
| GoToIfSet FLAG_MAP_LOCAL, AcuityCavern_RemoveUxie |
There was a problem hiding this comment.
question: Is this really local...? If so, what does "local" mean?
There was a problem hiding this comment.
As far as I can tell, this is being used in the same way as the VAR_MAP_LOCAL_ variables are, except it's a boolean value written to and read from like a flag, instead of being an integer like the VAR_MAP_LOCAL_ variables, so that terminology was copied.
2 participants
Document Gym scripts
Add macro for GoToIfBadgeAcquired