Document Poketch Link Searcher (Overlay 52) #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbroede
reviewed
Oct 31, 2025
res/text/poketch_link_searcher.json
Outdated
| }, | ||
| { | ||
| "id": "pl_msg_00000461_00009", | ||
| "id": "LinkSearcher_Text_OtherRooms", |
There was a problem hiding this comment.
Suggested change
| "id": "LinkSearcher_Text_OtherRooms", | |
| "id": "LinkSearcher_Text_OtherLinks", |
|
|
||
| static void PrintDontMoveError(LinkSearcherGraphics *graphics) | ||
| { | ||
|
|
There was a problem hiding this comment.
nitpick: remove empty line
| }; | ||
| static const u8 sOtherLinks[] = { | ||
| 0, 6, 8, 11, 12, 14, 16, 27, 28, 30, 31, 32 | ||
| }; |
There was a problem hiding this comment.
use more specific names for these consts
lhearachel
reviewed
Oct 31, 2025
Comment on lines
183
to
201
| switch (appData->subState) { | ||
| case 0: | ||
| if (ScreenIsPressed(appData)) { | ||
| if (CommStateIdle(appData)) { | ||
| FieldSystem *fieldSystem = PoketchSystem_GetFieldSystem(appData->poketchSys); | ||
|
|
||
| PoketchLinkSearcherGraphics_StartTask(appData->graphics, LINK_SEARCHER_GRAPHICS_SEARCHING); | ||
|
|
||
| if (MapHeader_IsPokemonCenter2(fieldSystem->location->mapId)) { | ||
| ChangeState(appData, STATE_UNUSABLE_ERROR); | ||
| } else { | ||
| ChangeState(appData, STATE_SHOW_RESULTS); | ||
| } | ||
| } else { | ||
| PoketchSystem_PlaySoundEffect(SEQ_SE_DP_BEEP); | ||
| } | ||
| } | ||
| break; | ||
| } |
There was a problem hiding this comment.
question: Does this match if you change the switch to if (appData->subState == 0)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link searcher makes use of a handful of undocumented functions, but based on the rest of the app I was able to guess functionality well enough to document the app fully. This app uses messages pulled from text banks much more than previous apps that I have seen, but otherwise doesn't have anything too exciting.
One interesting bit is the arrays in
UpdateLinkSearchResults(). I assume the array contents are some sort of link type ID, with the arrays breaking them down into categories. If these IDs are enumerated or documented anywhere, I couldn't find them.