-
Notifications
You must be signed in to change notification settings - Fork 9
small changes, prepare v1.5.0 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Prepares release 1.5.0 by bumping the project version and adding support for a new PASSKEY token type plus utility methods and improved HTTP response handling/logging.
- Adds PIResponse.hasChallenges() and passkey challenge handling in JSON parsing.
- Introduces PASSKEY token parsing branch and adjusts AsyncRequestCallable logging and resource management.
- Updates project version to 1.5.0 and reorders okhttp dependency.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/org/privacyidea/PIResponse.java | Adds hasChallenges() helper to detect presence of different challenge types. |
| src/main/java/org/privacyidea/JSONParser.java | Adds PASSKEY token type handling; imports constant and sets passkeyChallenge. |
| src/main/java/org/privacyidea/AsyncRequestCallable.java | Refactors response handling with try-with-resources and modifies logging logic. |
| pom.xml | Bumps artifact version to 1.5.0 and repositions okhttp dependency. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| else if (TOKEN_TYPE_PASSKEY.equals(type)) | ||
| { | ||
| response.passkeyChallenge = challenge.toString(); |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using challenge.toString() with Gson may serialize a JsonPrimitive string including quotes or a JsonObject's full JSON; if passkeyChallenge is expected to be the raw string value, use challenge.getAsString(). If an object is expected, assign challenge.getAsJsonObject() and adjust the target type.
| response.passkeyChallenge = challenge.toString(); | |
| response.passkeyChallenge = challenge.getAsString(); |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
No description provided.