Skip to content

Conversation

@nilsbehlen
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Prepares release 1.5.0 by bumping the project version and adding support for a new PASSKEY token type plus utility methods and improved HTTP response handling/logging.

  • Adds PIResponse.hasChallenges() and passkey challenge handling in JSON parsing.
  • Introduces PASSKEY token parsing branch and adjusts AsyncRequestCallable logging and resource management.
  • Updates project version to 1.5.0 and reorders okhttp dependency.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/main/java/org/privacyidea/PIResponse.java Adds hasChallenges() helper to detect presence of different challenge types.
src/main/java/org/privacyidea/JSONParser.java Adds PASSKEY token type handling; imports constant and sets passkeyChallenge.
src/main/java/org/privacyidea/AsyncRequestCallable.java Refactors response handling with try-with-resources and modifies logging logic.
pom.xml Bumps artifact version to 1.5.0 and repositions okhttp dependency.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}
else if (TOKEN_TYPE_PASSKEY.equals(type))
{
response.passkeyChallenge = challenge.toString();
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using challenge.toString() with Gson may serialize a JsonPrimitive string including quotes or a JsonObject's full JSON; if passkeyChallenge is expected to be the raw string value, use challenge.getAsString(). If an object is expected, assign challenge.getAsJsonObject() and adjust the target type.

Suggested change
response.passkeyChallenge = challenge.toString();
response.passkeyChallenge = challenge.getAsString();

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants