-
-
Notifications
You must be signed in to change notification settings - Fork 186
fix TypeError in agents and networks gis example #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a TypeError in the agents and networks GIS example by correcting function signatures and import statements across multiple RL model implementations.
- Removes redundant parameters from function signatures that were causing TypeErrors
- Fixes spelling errors in comments and documentation
- Updates import statements to use relative imports for proper module resolution
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rl/wolf_sheep/utility.py | Removes unnecessary parameters from function signatures and adds proper imports |
| rl/wolf_sheep/model.py | Updates import statement and function calls to match corrected signatures |
| rl/wolf_sheep/agents.py | Changes to relative import for utility module |
| rl/wolf_sheep/README.md | Fixes spelling error in documentation |
| rl/train.py | Replaces unused loop variable with underscore |
| rl/epstein_civil_violence/utility.py | Removes unnecessary parameters and adds imports |
| rl/epstein_civil_violence/model.py | Updates imports and function calls |
| rl/epstein_civil_violence/agent.py | Changes to relative import and fixes spelling |
| rl/epstein_civil_violence/README.md | Fixes spelling error |
| rl/boltzmann_money/server.py | Updates parameter name for consistency |
| rl/README.md | Fixes spelling error |
| gis/agents_and_networks/src/space/utils.py | Adds default parameter values |
| gis/agents_and_networks/references/GMU-Social.nlogo | Multiple spelling corrections |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This is basically an example update to Mesa 3.x right? |
|
No just a small fix for one gis example, and some ruff fixes (changing variable names etc) so that pre-commit can pass. |
EwoutH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, no remarks.
Thanks!
|
Awesome, thanks Ewout! |
No description provided.