feat!: New Prose Pod architecture #13
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…been committed" This reverts commit e9a5dd4.
Allows things like passing `--no-cache`.
`.dockerignore` as a syslink doesn’t work. Also Docker doesn’t search subdirectories and it has a different syntax to `.gitignore`. This was a bad idea in the first place.
RemiBardon
force-pushed
the
new-architecture
branch
from
4e77580 to
de4e310
Compare
Otherwise `prosody.sock` is created in `/etc/prosody`.
```log
modulemanager warn Not loading module, due to conflict with built-in features '{mod_cloud_notify}': /usr/local/lib/prosody/modules/mod_cloud_notify/mod_cloud_notify.lua
```
This way, we can pass format strings and get the correct module name in logs.
`.boxed()` would cause filters not to be applied.
RemiBardon
force-pushed
the
new-architecture
branch
from
0eed06a to
0947ba8
Compare
As noted in `app_config.rs`: ```rust // NOTE: We can’t reload logging layers because of a bug in `tracing` // (see tokio-rs/tracing#1629). Until // `tracing` 0.4 is released, we’ll just reload the filters, and // require a restart to change the logging format. This shouldn’t // bother anyone, as there is little point in changing the format // of logs at runtime. Filters, on the other hand, might be changed // at runtime and need to be reloadable. ```
RemiBardon
force-pushed
the
new-architecture
branch
2 times, most recently
from
6149208 to
13fd509
Compare
RemiBardon
force-pushed
the
new-architecture
branch
from
13fd509 to
27c6d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See prose-im/prose-pod-api#349.
Closes #12.