(CDPE-7090) Leverage $LASTEXITCODE for powershell jobs #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't completely understand what's going on, but somewhere in our 3-deep powershell script execution, the exit code of the CD4PE job is getting swallowed and turned into 0 every time. This results in a lot of false positives for users running jobs on windows agents. By adding this exit statement, pdk test unit, for example, will exit 1 when tests fail now. Rejoice.
eputnam
force-pushed
the
CDPE-7090/powershell-exit
branch
5 times, most recently
from
9d18637 to
cb2b271
Compare
The 'patron' gem requires us to install libcurl4 and libcurl4-openssl-dev to build its native extensions. 'patron' is a dependency of the module meta-gem.
eputnam
force-pushed
the
CDPE-7090/powershell-exit
branch
from
cb2b271 to
f624ce4
Compare
abottchen
approved these changes
Dec 16, 2024
Contributor
abottchen
left a comment
abottchen
left a comment
There was a problem hiding this comment.
Weird. Feels like this is what the script should be exiting with by default.
Contributor
Author
|
tests did not catch this because we run an invalid powershell script to test failure, not a valid script that fails. |
eputnam
force-pushed
the
CDPE-7090/powershell-exit
branch
2 times, most recently
from
956430d to
c08dcc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't completely understand what's going on, but somewhere in our 3-deep powershell script execution, the exit code of the CD4PE job is getting swallowed and turned into 0 every time. This results in a lot of false positives for users running jobs on windows agents. By adding this exit statement, pdk test unit, for example, will exit 1 when tests fail now. Rejoice.