(maint) Add logging when image pull fails #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds logging to indicate that we fall back to assuming a local version of the job image when pulling it from the remote fails. This should help users recognize that the pull errors are red herrings in air-gapped installs, and that the job will proceed, assuming the image has been loaded into the runtime out of band.
Contributor
Author
|
I tested this, seems to log appropriately. |
eputnam
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds logging to indicate that we fall back to assuming a local version of the job image when pulling it from the remote fails. This should help users recognize that the pull errors are red herrings in air-gapped installs, and that the job will proceed, assuming the image has been loaded into the runtime out of band.