Verify manifest images exist #4669 #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Offline feedback received, transitioning to draft PR:
|
JudahGabriel
approved these changes
May 28, 2025
Collaborator
|
This looks good, @jose-velarde. Ready to merge? |
Collaborator
Author
Yes @JudahGabriel, we're good to merge. There is also a PR for the app: pwa-builder/PWABuilder#4942, this one is a breaking change so whenever we go to production API should go first and then the app. |
JudahGabriel
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
PR Type
Describe the current behavior?
Images described in the manifest are not validated, thus they could not actually exist
Describe the new behavior?
/Report tries to fetch (HEAD request with fallback GET request) images described in the manifest
Additional Information
Format fix was applied to Report/index.ts