Skip to content

Conversation

@prady0t
Copy link
Collaborator

@prady0t prady0t commented Jul 19, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Related issues

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

Added a skip condition for size-zero arrays.

Signed-off-by: Pradyot Ranjan <[email protected]>
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 19, 2025

CodSpeed Performance Report

Merging #886 will degrade performances by 10.62%

Comparing prady0t:fix-check-zero-fill-value (13ed355) with main (a5d11a2)

Summary

⚑ 1 improvements
❌ 1 regressions
βœ… 338 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚑ test_index_fancy[side=100-rank=1-format='coo'] 1,300.9 ¡s 941.7 ¡s +38.14%
❌ test_index_slice[side=100-rank=2-format='gcxs'] 1.8 ms 2 ms -10.62%

@hameerabbasi
Copy link
Collaborator

Thanks for the fix, @prady0t! A test would help here.

@prady0t
Copy link
Collaborator Author

prady0t commented Jul 19, 2025

Thanks for the review. I've added the tests.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reproducer in the original issue can serve as a test, with a comment that it's a regression test for gh-*.

@prady0t
Copy link
Collaborator Author

prady0t commented Jul 19, 2025

I think the reproducer in the original issue can serve as a test, with a comment that it's a regression test for gh-*.

Makes sense.

Signed-off-by: Pradyot Ranjan <[email protected]>
@hameerabbasi hameerabbasi merged commit 2c3cf00 into pydata:main Jul 19, 2025
16 of 19 checks passed
@hameerabbasi
Copy link
Collaborator

Thanks @prady0t!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: mean -> matmul of size zero array fails

2 participants