Adding new component (Speakers) #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for global-conference-2025 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Can you add the component to the main page, so we can live-preview it? |
cmaureir
reviewed
Sep 29, 2025
src/components/speakers.astro
Outdated
| const lang = getLangFromUrl(Astro.url); | ||
| const t = useTranslations(lang); | ||
|
|
||
| const speakers = [ |
There was a problem hiding this comment.
We should explore how difficult could it be to connect this to a REST API query to pretalx and get the list already, or use a JSON.
egeakman
reviewed
Nov 1, 2025
There was a problem hiding this comment.
Thank you @codingisads! A few ideas we could explore:
- Define the SVGs externally instead of inline, if possible?
- Make the entire speaker container clickable, not just their avatars.
- Sort speakers alphabetically rather than by ID.
Let me know your thoughts, happy to help experiment with these!
|
Hey @egeakman, what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #48
This PR adds the speakers component. Hardcoded speaker info is currently shown, must be replaced in the future with the 2025 speakers info.
@cmaureir would love feedback! 🫡
Videos and screenshots:
Video.sin.titulo.Hecho.con.Clipchamp.mp4