Skip to content

Conversation

@jemand771
Copy link
Contributor

hi!

seeing how quickly I could get someone to add git-lfs, I have another proposal:

Currently, yasm inexplicably only exists in the final images for manylinux2014 and RHEL-like images, e.g. the almalinux-based manylinux_2_28 (the cibuildwheel default for manylinux)
Other images like the alpine-based musllinux_1_2 (the cibuildwheel default for musllinux) don't have it, and I'm not sure if that is intentional.

The goal here is to a) get a consistent set of tools between variants (or at least coincidentally work towards that) and b) because some projects need yasm/nasm to compile, e.g. ffmpeg. Since some images already had yasm, I figured it should be fine to include it in all of them.

Helpful links: cibuildwheel's default image versions and more importantly the default image variants

I let this build on github actions in my fork and only two matrix branches failed, neither of which should even be changed by my PR:

The errors look unrelated to my change and only seem to happen on "funky" architectures, maybe that's normal

@mayeut
Copy link
Member

mayeut commented Nov 7, 2025

Thanks for getting this consistent across images.

The errors look unrelated to my change and only seem to happen on "funky" architectures, maybe that's normal

They are unrelated. Will try to address the gnu sources download instability by using mirrors. Can't do much about riscv64 mirrors though, need to restart until it passes...

@mayeut mayeut merged commit 6123957 into pypa:main Nov 7, 2025
77 of 84 checks passed
@jemand771 jemand771 deleted the yasm-everywhere branch November 7, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants