Skip to content

Conversation

@camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Aug 29, 2024

Describe the changes

Adding tests to document subtle pyfakefs differences described in issue 1053

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing
  • For documentation changes: The Read the Docs preview builds and looks as expected

@mrbean-bremen
Copy link
Member

@camillobruni - I have added a commit that shall fix most of the issues, but I still got one failing test (test_real_file_with_home) under Posix and Python < 3.12, which I have disabled at the moment.
Can you please check how this version works for you?

@mrbean-bremen mrbean-bremen force-pushed the 2024-08-26_pure_path_diff branch from 6bea1fe to 519dcbf Compare September 8, 2024 06:39
Copy link
Contributor

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read all of this but wanted to offer feedback for what I did see.

@mrbean-bremen mrbean-bremen force-pushed the 2024-08-26_pure_path_diff branch from 519dcbf to ef5a004 Compare September 10, 2024 16:40
@mrbean-bremen
Copy link
Member

I haven't read all of this but wanted to offer feedback for what I did see.

Another pair of eyes is always helpful, especially as I rarely get reviews here. Given enough eyeballs...

@camillobruni
Copy link
Contributor Author

Late reply back from vacation: thanks a lot for these fixes!

@mrbean-bremen mrbean-bremen force-pushed the 2024-08-26_pure_path_diff branch from ef5a004 to 68ab974 Compare September 13, 2024 18:07
@mrbean-bremen mrbean-bremen force-pushed the 2024-08-26_pure_path_diff branch from 68ab974 to f6a987f Compare September 14, 2024 18:11
@mrbean-bremen
Copy link
Member

@camillobruni - I added a workaround to get the failing test running, and I would merge this if you give your ok. Did you have a chance to test it?
Oh, and I forgot the release notes, will add these before merging, of course.

@mrbean-bremen mrbean-bremen changed the title [WIP]: Add tests documenting pyfakefs vs pathlib differences Fix some problems with pathlib PosixPath/WindowsPath behavior Sep 14, 2024
@camillobruni
Copy link
Contributor Author

Cool, double checked locally and I got the tests working with this 👍

@mrbean-bremen mrbean-bremen force-pushed the 2024-08-26_pure_path_diff branch from f6a987f to 5da4438 Compare September 17, 2024 16:42
@mrbean-bremen mrbean-bremen merged commit da7bd5d into pytest-dev:main Sep 17, 2024
mrbean-bremen pushed a commit that referenced this pull request Sep 17, 2024
Copy link

@ossieoj3 ossieoj3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants