Skip to content

fix: Remove unnecessary string casting of bytes #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2024
Merged

fix: Remove unnecessary string casting of bytes #276

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b2421a
fix: Remove unnecessary string casting of `bytes`
BYK Nov 14, 2024
10a3fae
even faster
BYK Nov 15, 2024
f90010e
Merge branch 'master' into byk/fix/byte-str-cast
BYK Nov 16, 2024
fb65910
better naming and comment
BYK Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/hpack/hpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,16 @@ def _dict_to_iterable(header_dict):
yield key, header_dict[key]


def _to_bytes(string):
def _to_bytes(value):
"""
Convert string to bytes.
Convert anything to bytes through a UTF-8 encoded string
"""
if not isinstance(string, basestring): # pragma: no cover
string = str(string)

return string if isinstance(string, bytes) else string.encode('utf-8')
t = type(value)
if t is bytes:
return value
if t is not str:
value = str(value)
return value.encode("utf-8")


class Encoder:
Expand Down
Loading