Skip to content

Use enums for Modes and RawModes in C #9256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 70 commits into from
Oct 15, 2025
Merged

Use enums for Modes and RawModes in C #9256

merged 70 commits into from
Oct 15, 2025
+1,717 −1,124

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Oct 15, 2025

#9100, plus eyedav#3, and with the merge conflicts fixed.

Yay295 and others added 30 commits July 19, 2025 14:29
@Yay295 @eyedav
use a struct for mode names instead of just a string
cd93629
@Yay295 @eyedav
add special modes
63a45ad
@eyedav
use mode structs in _imaging.c
12409e4
@Yay295 @eyedav
use mode structs in tkImaging.c
a37f53c
@eyedav
use mode structs in encode.c and decode.c
a12dc30
@eyedav
use mode structs in Access.c
0df2ed0
@Yay295 @eyedav
use mode structs in AlphaComposite.c
82182ba
@Yay295 @eyedav
use mode structs in Bands.c
d0541a7
@Yay295 @eyedav
use mode structs in Blend.c
38c75b9
@Yay295 @eyedav
use mode structs in BoxBlur.c
6f6e1f9
@Yay295 @eyedav
use mode structs in Chops.c
ecf1fce
@eyedav
use mode structs in Convert.c
9bf3495
@eyedav
use mode structs in Draw.c
bcfe5f2
@Yay295 @eyedav
use mode structs in Effects.c
b5c4b82
@Yay295 @eyedav
use mode structs in File.c
19c0d1d
@Yay295 @eyedav
use mode structs in Fill.c
6202eef
@eyedav
use mode structs in Filter.c
af22363
@Yay295 @eyedav
use mode structs in Geometry.c
cfe9155
@Yay295 @eyedav
use mode structs in GetBBox.c
2668338
@Yay295 @eyedav
use mode structs in Histo.c
2749770
@Yay295 @eyedav
use mode structs in Jpeg2KDecode.c
3327258
@Yay295 @eyedav
use mode structs in Jpeg2KEncode.c
98a2c63
@Yay295 @eyedav
use mode structs in JpegDecode.c
30d4cd0
@Yay295 @eyedav
use mode structs in JpegEncode.c
0abfdd2
@Yay295 @eyedav
use mode structs in Matrix.c
378c3bd
@eyedav
add function isModeI16() to check if a mode is an I;16 mode
4906285
@eyedav
use mode structs in Pack.c
e5bc5b4
@Yay295 @eyedav
use mode structs in Palette.c
af3c24e
@Yay295 @eyedav
use mode structs in Paste.c
2a9d712
@Yay295 @eyedav
use mode structs in Point.c
7e48697
Yay295 and others added 18 commits July 19, 2025 17:00
@Yay295 @eyedav
use a different temp build dir for each module
e483a97
@eyedav
build Mode.c as a common library
28adda9
@Yay295 @eyedav
add debug check that all modes and rawmodes are defined
0567f06
@Yay295 @eyedav
use mode enums in _imagingcms.c
2f169fa
@eyedav
require types-setuptools>=75.2.0
d82576f 
this is necessary to have python/typeshed#12791
@eyedav
linter changes
84aa437
@wiredfool
Fix Compliation errors from rebase
adfb66f
@radarhere
Merge branch 'main' into mode_enums
726de49
@radarhere
Removed setuptools version requirement
59d6f31
@radarhere
pre-commit fixes
ed164d1
@radarhere
Updated formatting
178b3a7
@radarhere
Restored unpacker
84e89bf
@radarhere
Merge branch 'main' into mode_enums
b33254f
@wiredfool @hugovk
Typing import suggestion
2b4c7c0 
Co-authored-by: Hugo van Kemenade <[email protected]>
@wiredfool
Check against mode 1 instead of input mode for Chops.c
bd6e70f
@radarhere
Removed BGR;24 and BGR;32
a591000
@radarhere
Removed BGR;15 and BGR;16 modes
55a4901
@radarhere
Merge branch 'main' into mode_enums
4fbe28a
@hugovk hugovk added this to the 12.0.0 milestone Oct 15, 2025
@hugovk hugovk added the automerge Automatically merge PRs that are ready label Oct 15, 2025
@mergify mergify bot merged commit 5dddb2c into python-pillow:main Oct 15, 2025
70 of 71 checks passed
@radarhere radarhere deleted the mode_enums branch October 15, 2025 11:12
@kmilos
Copy link
Contributor

kmilos commented Oct 16, 2025

It seems the common Mode.c library fails to build OOTB in MSYS2 LLVM based environments like CLANG64/CLANGARM64:

https://github.com/msys2/MINGW-packages/actions/runs/18555260796/job/52891070931?pr=25966#step:10:466

It does build in MSYS2 GCC based environments like UCRT64/MINGW64:

https://github.com/msys2/MINGW-packages/actions/runs/18555260796/job/52891070947?pr=25966#step:10:464

The Pillow CI covers MINGW64 only.

@kmilos kmilos mentioned this pull request Oct 16, 2025
Merged
@radarhere
Copy link
Member Author

radarhere commented Oct 16, 2025

Would you mind opening a new issue?

All I'm seeing in the logs is error: command '/clangarm64/bin/llvm-ar' failed: None, which isn't terribly informative. Can you see anything else that's more helpful?

@kmilos kmilos mentioned this pull request Oct 16, 2025
Open
@kmilos
Copy link
Contributor

kmilos commented Oct 16, 2025

Would you mind opening a new issue?

Done.

@radarhere radarhere mentioned this pull request Oct 22, 2025
Open
@radarhere radarhere mentioned this pull request Nov 5, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

automerge Automatically merge PRs that are ready

Projects

None yet

Milestone

12.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@radarhere @kmilos @hugovk @Yay295 @eyedav @wiredfool