gh-143198: fix SIGSEGV in sqlite3.executemany with concurrent mutations
#143210
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt parameter iterator
picnixz
requested review from
berkerpeksag and
erlend-aasland
as code owners
picnixz
commented
Dec 27, 2025
Misc/NEWS.d/next/Library/2025-12-27-10-36-18.gh-issue-143198.DdIHyC.rst
Outdated
Show resolved
Hide resolved
picnixz
added
needs backport to 3.13
picnixz
changed the title
sqlite3.execute[many] with re-entrant parameter iteratorsqlite3.execute[many] with concurrent mutations
picnixz
changed the title
sqlite3.execute[many] with concurrent mutationssqlite3.executemany with concurrent mutations
tomasr8
approved these changes
Dec 27, 2025
picnixz
commented
Dec 27, 2025
| } | ||
| // PyIter_Next() may have a side-effect on the connection's state. | ||
| // See: https://github.com/python/cpython/issues/143198. | ||
| if (!pysqlite_check_connection(self->connection)) { |
Member
Author
There was a problem hiding this comment.
Suggested change
| if (!pysqlite_check_connection(self->connection)) { | |
| if (multiple && !pysqlite_check_connection(self->connection)) { |
Strictly speaking, this check is redundant when dealing with mutliple = 0 because parameters_iter is a true list_iterator that is safely constructed and parameters may be an evil one. With multiple = 1, we need to check this at every iteration as parameters_iter may come from user-defined code.
picnixz
commented
Dec 27, 2025
| if (!parameters) { | ||
| break; | ||
| } | ||
| // PyIter_Next() may have a side-effect on the connection's state. |
Member
Author
There was a problem hiding this comment.
Note: if parameters is NULL and we have an active exception, we break the loop. It should only happen when we are having a custom iterator, that is, multiple = 1. As such, we wouldn't branch into the if (!multiple) and we wouldn't call PyLong_FromLongLong.
However, I'll add tomorrow some assertions because it's not entirely clear from the code alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FTR, the reason why
executeis actually not affected is that the iterator we are taking is built from a list we create ourselves so it's not possible to have "bad" side effects._sqlitecursor cache via re-entrant parameter iterator #143198