Refactor TBE benchmark reporter to use structured data config #5260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookresearch/FBGEMM#2251 This change refactors the TBE benchmark params reporter to properly structure feature maps (`Es`, `Ds`, `Bs`, `Ls`, `feature_table_map`) within the appropriate data classes instead of adding them as ad-hoc fields to the JSON output. **Changes:** - Added `Ls` (list of pooling factors) field to `PoolingParams` dataclass - Added `feature_table_map` field to `TBEDataConfig` dataclass - Updated `extract_params()` to properly populate `Es`, `Ds` in `TBEDataConfig`, `Bs` in `BatchParams`, and `Ls` in `PoolingParams` - Removed all ad-hoc code that was manually adding these fields to the JSON output - Updated `SplitTableBatchedEmbeddingBagsCodegen.forward()` to pass `feature_table_map` to the reporter Differential Revision: D89408478
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2251
This change refactors the TBE benchmark params reporter to properly structure feature maps (
Es,Ds,Bs,Ls,feature_table_map) within the appropriate data classes instead of adding them as ad-hoc fields to the JSON output.Changes:
Ls(list of pooling factors) field toPoolingParamsdataclassfeature_table_mapfield toTBEDataConfigdataclassextract_params()to properly populateEs,DsinTBEDataConfig,BsinBatchParams, andLsinPoolingParamsSplitTableBatchedEmbeddingBagsCodegen.forward()to passfeature_table_mapto the reporterDifferential Revision: D89408478