Skip to content

Conversation

@apbose
Copy link
Collaborator

@apbose apbose commented Nov 5, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla bot added the cla signed label Nov 5, 2025
@apbose apbose marked this pull request as draft November 5, 2025 08:36
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 5, 2025
@apbose apbose changed the title Abose/dlfw 25.11 changes [WIP] DLFW 25.11 changes [WIP] Nov 5, 2025
…to torch) and make ATenAnyDimNegIndexConvertsCorrectly input deterministic on ORIN
@apbose apbose force-pushed the abose/DLFW_25.11_changes branch from c9deb1d to f76f1d9 Compare November 6, 2025 18:00
@apbose apbose marked this pull request as ready for review November 6, 2025 18:01
@apbose apbose requested a review from lanluo-nvidia November 6, 2025 22:03
@apbose apbose changed the title DLFW 25.11 changes [WIP] DLFW 25.11 changes Nov 6, 2025
@apbose apbose force-pushed the abose/DLFW_25.11_changes branch from 61764e0 to 3004423 Compare November 7, 2025 21:34
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py	2025-11-07 21:34:26.382463+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py	2025-11-07 21:35:02.881747+00:00
@@ -439,11 +439,12 @@
    return True


@dynamo_tensorrt_converter(
    torch.ops.aten.index.Tensor,
-    capability_validator=lambda node, settings: index_dtype_validator(node, settings) and index_nonbool_validator(node, settings),
+    capability_validator=lambda node, settings: index_dtype_validator(node, settings)
+    and index_nonbool_validator(node, settings),
    supports_dynamic_shapes=True,
    requires_output_allocator=True,
)
@enforce_tensor_types(
    {

@apbose apbose force-pushed the abose/DLFW_25.11_changes branch from 3004423 to 8162718 Compare November 7, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants