-
Notifications
You must be signed in to change notification settings - Fork 363
support eval of float8_a1x128_w128x128 #3269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
990ef89
Update
vkuzo cce08f0
Update
vkuzo 681277a
Update
vkuzo 26ade98
Update
vkuzo f76e10b
Update
vkuzo 6994e20
Update
vkuzo 1aff468
Update
vkuzo f6fa134
Update
vkuzo 1911212
Update
vkuzo 9ec8ce1
Update
vkuzo 57b8876
Update
vkuzo 1161f7f
Update
vkuzo c5be7c0
Update
vkuzo 00c6bbb
Update
vkuzo d40ec7c
Update
vkuzo ce5a8eb
Update
vkuzo be5a9bb
Update
vkuzo 6a3684b
Update
vkuzo 1d4a2f7
Update
vkuzo d28b0ae
Update
vkuzo 6c087b4
Update
vkuzo 4de79c9
Update
vkuzo 1938209
Update
vkuzo c4769a6
Update
vkuzo eb95772
Update
vkuzo 526b741
Update
vkuzo 22d1a14
Update
vkuzo 76671f9
Update
vkuzo 4a29159
Update
vkuzo 9a995b5
Update
vkuzo c877d67
Update
vkuzo 485ee80
Update
vkuzo cafe668
Update
vkuzo 2dacafc
Update
vkuzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The evaluation framework for torchao has multiple scripts:
torchao/_models/llama/eval.py
benchmarks/_models/eval_hf_models.py, which will need to be cleaned up as part of BE #3289. For now I feel the quantization technique should also be added to the benchmarking framework here:
ao/benchmarks/microbenchmarks/utils.py
Lines 153 to 155 in 01374eb
This will enable
float8_a1x128_w128x128in the torchao benchmarking module, and running it on hf modelsRest, LGTM!