-
Notifications
You must be signed in to change notification settings - Fork 389
make eval script also handle performance measurement #3473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3473
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6896527 with merge base 486fe0d ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: e1d713e ghstack-comment-id: 3634216524 Pull-Request: #3473
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 15f7481 ghstack-comment-id: 3634216524 Pull-Request: #3473
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 15f7481 ghstack-comment-id: 3634216524 Pull-Request: #3473
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 665f2c8 ghstack-comment-id: 3634216524 Pull-Request: #3473
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: cae97ab ghstack-comment-id: 3634216524 Pull-Request: #3473
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 42466df ghstack-comment-id: 3634216524 Pull-Request: #3473
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 79c5722 ghstack-comment-id: 3634216524 Pull-Request: #3473
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: a0019d4 ghstack-comment-id: 3634216524 Pull-Request: #3473
Summary: 1. refactors the eval script to also handle performance measurement in vllm 2. adds a simple `vllm bench latency` script to bench in vllm The script is broken on every single recipe, we'll have to fix and enable things in future PRs, will update the performance tables afterwards. Also, add convenience flags to skip model creation, lm_eval, vllm as needed to enable running just a single model + single step. Test Plan: ``` SKIP_MODEL_CREATE=1 SKIP_LM_EVAL=1 SKIP_VLLM=0 with-proxy ./benchmarks/quantization/measure_accuracy_and_performance.sh h100 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 404c330 ghstack-comment-id: 3634216524 Pull-Request: #3473
jainapurva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Summary:
vllm
vllm bench latencyscript to bench in vllm for prefill and decodeAlso, add convenience flags to skip model creation, lm_eval, vllm as
needed to enable running just a single model + single step.
Test Plan:
Results (on H100):
Reviewers:
Subscribers:
Tasks:
Tags: