-
Notifications
You must be signed in to change notification settings - Fork 389
Parse device at model release script #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3486
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
| # Validate CUDA devicedevice | ||
| try: | ||
| device = torch.device(args.device) | ||
| if not torch.cuda.is_available(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why checking cuda here if have a device arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the wrong check because user might fail to pass with --device cpu; removed redundant validation block.
7c7da3d to
c5014d3
Compare
Summary:
Add
deviceas a parser for custom GPU usage likecuda:1.model_id & quantparsers are updated to require input.Test Plan:
python .github/scripts/torchao_model_releases/quantize_and_upload.py --model_id Qwen/Qwen3-8B --quant AWQ-INT4