Skip to content

pin bump optimum #15912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pin bump optimum #15912

wants to merge 2 commits into from
+1 −1

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Nov 20, 2025

Summary: bump up optimum to keep sdpa kernel not being decomposed during lowering to cuda delegate

Differential Revision: D87519599

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15912

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87519599.

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@larryliu0820
Copy link
Contributor

larryliu0820 commented Nov 20, 2025

why jobs are canceled

larryliu0820
larryliu0820 approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@Gasoonjia @facebook-github-bot
pin bump optimum (#15912)
c9136eb 
Summary:

bump up optimum to keep sdpa kernel not being decomposed during lowering to cuda delegate

Reviewed By: larryliu0820

Differential Revision: D87519599
@meta-codesync
Copy link

meta-codesync bot commented Nov 21, 2025

@Gasoonjia has imported this pull request. If you are a Meta employee, you can view this in D87519599.

@Gasoonjia Gasoonjia temporarily deployed to upload-benchmark-results November 21, 2025 22:33 — with GitHub Actions Inactive
@Gasoonjia Gasoonjia temporarily deployed to upload-benchmark-results November 22, 2025 00:10 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gasoonjia @larryliu0820