Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Nov 20, 2025

Summary:

  1. Use ExecutorchBackendConfig instead of inserting the pass.
  2. Move SpecPropPass after user-defined passes. It was originally swapped here: D80840528. cc ethansfng, who has a pass that should run before SpecPropPass

Differential Revision: D87576772

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15932

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit bd92f7a with merge base b4d72f1 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87576772.

Summary:

Adding a Callable option in the config, so we can customize the nodes to save, and the filenames to save to. 

The pass is applied in _program.py, it's hard to do this on the eager model (like we do with delegates) as we have to run the pass after SpecPropPass.

Reviewed By: ethansfng

Differential Revision: D87280747
Summary:
1. Use `ExecutorchBackendConfig` instead of inserting the pass.
2. Move SpecPropPass after user-defined passes. It was originally swapped here: D80840528. cc ethansfng, who has a pass that should run before SpecPropPass

Differential Revision: D87576772
@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87576772.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant