Add Python 3.13 support #16004

PetarTerziev-UL · 2025-11-27T15:06:43Z

Summary

coremltools versions prior to 9.0 did not support Python 3.13. Now executorch uses 9.0, we can finally enable building wheels with Python 3.13.

Fixes #8292

Test plan

Python test suite ran and compared against a dev install of the target branchh in a 3.12 virtual environment.

pytorch-bot · 2025-11-27T15:06:47Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16004

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 160 Pending, 2 Unrelated Failures

As of commit 56002a2 with merge base 31aa8d3 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / test-huggingface-transformers-macos (olmo-1b|coreml_fp32_gpu|--quantize) / macos-job (gh) (detected as infra flaky with no log or failing log classifier)

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / android / run-emulator (gh) (#16137)
Timeout waiting for emulator to boot.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

PetarTerziev-UL · 2025-11-27T15:11:35Z

I need to add a "release notes: misc" label, but I don't seem to have the ability to.

PetarTerziev-UL · 2025-11-28T17:28:47Z

the tests under examples/models/llama3_2_vision/preprocess hang on a call into AOTInductor when torch nightly is installed.

Need to look into this further.

PetarTerziev-UL · 2025-12-01T15:10:22Z

the tests under examples/models/llama3_2_vision/preprocess hang on a call into AOTInductor when torch nightly is installed.

Need to look into this further.

Things are better in with a newer nightly build of torch, so I've bumped the pinned version as part of this PR too.

Copilot

Pull request overview

This PR adds Python 3.13 support to ExecuTorch now that coremltools 9.0 (which supports Python 3.13) is available. The changes update version constraints, documentation, and CI/CD workflows to enable building wheels for Python 3.13.

Key changes:

Update Python version constraint from <3.13 to <3.14 in pyproject.toml
Add Python 3.13 to wheel building workflows and documentation
Remove Python 3.13 warning from CoreML troubleshooting documentation
Update nightly version pin (unrelated maintenance update)

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pyproject.toml	Add Python 3.13 classifier, update requires-python constraint to `<3.14`, add py313 to ruff target-version
torch_pin.py	Update nightly version from dev20251025 to dev20251124
docs/source/*.md	Update Python version requirements from 3.10-3.12 to 3.10-3.13 across multiple documentation files
docs/source/backends/coreml/coreml-troubleshooting.md	Remove outdated Python 3.13 compatibility warning
README-wheel.md	Add Python 3.13 to list of supported versions
.github/workflows/*.yml	Add "3.13" to Python version matrices for wheel building workflows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-01T20:42:38Z

pyproject.toml

 ]

 # Python dependencies required for use.
 # coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487


The comment is now outdated since Python 3.13 is being supported. Either remove the comment entirely or update it to reflect that the issue was resolved in coremltools 9.0 (e.g., '# coremltools 9.0+ supports python 3.13, see apple/coremltools#2487').

Suggested change

# coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487

# coremltools 9.0+ supports python 3.13, see https://github.com/apple/coremltools/issues/2487

larryliu0820 · 2025-12-01T20:48:41Z

pyproject.toml

 ]

 # Python dependencies required for use.
 # coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487


Delete this comment?

larryliu0820 · 2025-12-01T21:53:13Z

@PetarTerziev-UL can you please bump the nightly version of pytorch to 1122 instead? I think the nightly job failed to build 1124 nightly.

PetarTerziev-UL · 2025-12-02T10:59:18Z

@PetarTerziev-UL can you please bump the nightly version of pytorch to 1122 instead? I think the nightly job failed to build 1124 nightly.

Done! Is there a way to check nightly job statuses? I was looking at wheels available at download.pytorch.org and drawing assumptions.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T07:59:38Z

pyproject.toml

 # specified by `requires-python`. TODO: Remove this once we support these older
 # versions of python and can expand the `requires-python` range.
-target-version = ["py38", "py39", "py310", "py311", "py312"]
+target-version = ["py38", "py39", "py310", "py311", "py312", "py313"]


The target-version includes py38 and py39, but requires-python specifies >=3.10. This mismatch means Ruff is configured to support Python versions below the project's minimum requirement. Either remove py38 and py39 from target-version to align with requires-python, or update the comment on line 132-133 to explain why these older versions are still targeted.

Suggested change

target-version = ["py38", "py39", "py310", "py311", "py312", "py313"]

target-version = ["py310", "py311", "py312", "py313"]

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-11T16:44:24Z

runtime/core/portable_type/c10/torch/headeronly/macros/Macros.h


+// Compile-time switch to control how assertions are logged inside CUDA kernels.
+// If C10_CUDA_VERBOSE_ASSERT is defined,  CUDA_KERNEL_ASSERT_VERBOSE will
+// take addition information passed to the macro and forward them to


Corrected spelling of 'addition' to 'additional'.

Suggested change

// take addition information passed to the macro and forward them to

// take additional information passed to the macro and forward them to

mergennachin · 2025-12-11T16:47:25Z

@PetarTerziev-UL

Do you need specifically torch 11-22 nightly?

I am trying to upgrade to 11-20 in this PR

#16198

PetarTerziev-UL · 2025-12-11T16:48:43Z

@PetarTerziev-UL

Do you need specifically torch 11-22 nightly?

I am trying to upgrade to 11-20 in this PR

#16198

@mergennachin Nope, that's also fine. Happy to wait for that to go in first?

@PetarTerziev-UL

Upgrading the torch pin, that would be useful for #16004 Also incorporating issues found by @PetarTerziev-UL

coremltools versions prior to 9.0 did not support Python 3.13. Now executorch uses 9.0, we can finally enable building wheels with Python 3.13.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pytorch-bot · 2025-12-12T18:09:53Z

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

kirklandsign · 2025-12-12T20:23:00Z

Seems to cause windows issue https://github.com/pytorch/executorch/actions/runs/20177557359/job/57929443045

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2025

PetarTerziev-UL marked this pull request as ready for review December 1, 2025 15:10

PetarTerziev-UL requested a review from mergennachin as a code owner December 1, 2025 15:10

mergennachin requested review from GregoryComer and Copilot December 1, 2025 20:38

mergennachin added ciflow/trunk ciflow/binaries ciflow/binaries/all Release PRs with this label will build wheels for all python versions labels Dec 1, 2025

Copilot started reviewing on behalf of mergennachin December 1, 2025 20:38 View session

mergennachin requested a review from larryliu0820 December 1, 2025 20:40

Copilot finished reviewing on behalf of mergennachin December 1, 2025 20:40

mergennachin requested a review from JacobSzwejbka December 1, 2025 20:40

mergennachin added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Dec 1, 2025

Copilot AI reviewed Dec 1, 2025

View reviewed changes

larryliu0820 reviewed Dec 1, 2025

View reviewed changes

larryliu0820 added the release notes: misc Miscellaneous label Dec 1, 2025

PetarTerziev-UL force-pushed the pt/py313 branch from 7fbf70d to 6bf40e1 Compare December 2, 2025 10:56

pytorch-bot bot removed ciflow/trunk ciflow/binaries ciflow/binaries/all Release PRs with this label will build wheels for all python versions labels Dec 2, 2025

PetarTerziev-UL force-pushed the pt/py313 branch from 6bf40e1 to 85b5a4f Compare December 3, 2025 07:59

Copilot AI review requested due to automatic review settings December 3, 2025 07:59

Copilot AI reviewed Dec 3, 2025

View reviewed changes

PetarTerziev-UL force-pushed the pt/py313 branch from 85b5a4f to 78aaa50 Compare December 3, 2025 10:09

PetarTerziev-UL force-pushed the pt/py313 branch 2 times, most recently from a551285 to c1adb09 Compare December 8, 2025 15:41

mergennachin added ciflow/trunk ciflow/binaries labels Dec 10, 2025

Copilot AI review requested due to automatic review settings December 11, 2025 16:43

PetarTerziev-UL force-pushed the pt/py313 branch from c1adb09 to c4f39c7 Compare December 11, 2025 16:43

PetarTerziev-UL requested review from jackzhxng and lucylq as code owners December 11, 2025 16:43

pytorch-bot bot removed ciflow/trunk ciflow/binaries labels Dec 11, 2025

Copilot AI reviewed Dec 11, 2025

View reviewed changes

mergennachin mentioned this pull request Dec 11, 2025

Update torch pin to 11-20 #16198

Merged

mergennachin added a commit that referenced this pull request Dec 11, 2025

Update torch pin to 11-20 (#16198)

8eb2272

Upgrading the torch pin, that would be useful for #16004 Also incorporating issues found by @PetarTerziev-UL

PetarTerziev-UL force-pushed the pt/py313 branch from c4f39c7 to 1d52f89 Compare December 11, 2025 20:29

mergennachin added the ciflow/binaries label Dec 11, 2025

Add Python 3.13 support

56002a2

coremltools versions prior to 9.0 did not support Python 3.13. Now executorch uses 9.0, we can finally enable building wheels with Python 3.13.

PetarTerziev-UL force-pushed the pt/py313 branch from 1d52f89 to 56002a2 Compare December 12, 2025 18:00

Copilot AI review requested due to automatic review settings December 12, 2025 18:00

pytorch-bot bot removed the ciflow/binaries label Dec 12, 2025

Copilot AI reviewed Dec 12, 2025

View reviewed changes

mergennachin added ciflow/binaries ciflow/trunk labels Dec 12, 2025

pytorch-bot bot removed the ciflow/trunk label Dec 12, 2025

mergennachin added the ciflow/trunk label Dec 12, 2025

mergennachin approved these changes Dec 12, 2025

View reviewed changes

mergennachin merged commit 4aaa3ae into pytorch:main Dec 12, 2025
327 of 340 checks passed

	# coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487
	# coremltools 9.0+ supports python 3.13, see https://github.com/apple/coremltools/issues/2487

	target-version = ["py38", "py39", "py310", "py311", "py312", "py313"]
	target-version = ["py310", "py311", "py312", "py313"]

	// take addition information passed to the macro and forward them to
	// take additional information passed to the macro and forward them to

Add Python 3.13 support #16004

Add Python 3.13 support #16004

Conversation

PetarTerziev-UL commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

pytorch-bot bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16004

⏳ 160 Pending, 2 Unrelated Failures

Uh oh!

PetarTerziev-UL commented Nov 27, 2025

Uh oh!

PetarTerziev-UL commented Nov 28, 2025

Uh oh!

PetarTerziev-UL commented Dec 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

larryliu0820 Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

larryliu0820 commented Dec 1, 2025

Uh oh!

PetarTerziev-UL commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

mergennachin commented Dec 11, 2025

Uh oh!

PetarTerziev-UL commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

pytorch-bot bot commented Dec 12, 2025

Uh oh!

Uh oh!

kirklandsign commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PetarTerziev-UL commented Nov 27, 2025 •

edited

Loading

pytorch-bot bot commented Nov 27, 2025 •

edited

Loading