Skip to content

[Test] Fix flaky tests #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[Test] Fix flaky tests #3233

wants to merge 16 commits into from

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Nov 7, 2025

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3233

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 154. Improved: $\large\color{#35bf28}28$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 83.8685μs 82.5946μs 12.1073 KOps/s 11.6576 KOps/s $\color{#35bf28}+3.86\%$
test_tensor_to_bytestream_speed[torch.save] 0.1426ms 0.1420ms 7.0447 KOps/s 6.8184 KOps/s $\color{#35bf28}+3.32\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1155s 0.1152s 8.6817 Ops/s 8.1813 Ops/s $\textbf{\color{#35bf28}+6.12\%}$
test_tensor_to_bytestream_speed[numpy] 2.9738μs 2.9673μs 337.0078 KOps/s 351.7634 KOps/s $\color{#d91a1a}-4.19\%$
test_tensor_to_bytestream_speed[safetensors] 42.7167μs 42.3223μs 23.6282 KOps/s 22.4851 KOps/s $\textbf{\color{#35bf28}+5.08\%}$
test_simple 0.5563s 0.5542s 1.8045 Ops/s 1.7225 Ops/s $\color{#35bf28}+4.76\%$
test_transformed 1.2358s 1.1418s 0.8758 Ops/s 0.8694 Ops/s $\color{#35bf28}+0.74\%$
test_serial 1.6705s 1.6660s 0.6003 Ops/s 0.5886 Ops/s $\color{#35bf28}+1.99\%$
test_parallel 1.1689s 1.0995s 0.9095 Ops/s 0.9147 Ops/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-True-True-True-True] 0.2793ms 45.5922μs 21.9336 KOps/s 21.5853 KOps/s $\color{#35bf28}+1.61\%$
test_step_mdp_speed[True-True-True-True-False] 58.2210μs 25.0006μs 39.9990 KOps/s 39.0195 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[True-True-True-False-True] 59.3210μs 25.1998μs 39.6828 KOps/s 38.1923 KOps/s $\color{#35bf28}+3.90\%$
test_step_mdp_speed[True-True-True-False-False] 45.9510μs 13.8218μs 72.3495 KOps/s 70.6580 KOps/s $\color{#35bf28}+2.39\%$
test_step_mdp_speed[True-True-False-True-True] 86.6320μs 47.5658μs 21.0235 KOps/s 20.3344 KOps/s $\color{#35bf28}+3.39\%$
test_step_mdp_speed[True-True-False-True-False] 56.3500μs 27.3000μs 36.6300 KOps/s 34.7100 KOps/s $\textbf{\color{#35bf28}+5.53\%}$
test_step_mdp_speed[True-True-False-False-True] 95.2520μs 27.7902μs 35.9839 KOps/s 34.2161 KOps/s $\textbf{\color{#35bf28}+5.17\%}$
test_step_mdp_speed[True-True-False-False-False] 60.0410μs 16.5378μs 60.4674 KOps/s 59.2724 KOps/s $\color{#35bf28}+2.02\%$
test_step_mdp_speed[True-False-True-True-True] 0.1099ms 50.4235μs 19.8320 KOps/s 19.3415 KOps/s $\color{#35bf28}+2.54\%$
test_step_mdp_speed[True-False-True-True-False] 66.7410μs 30.1595μs 33.1570 KOps/s 31.6391 KOps/s $\color{#35bf28}+4.80\%$
test_step_mdp_speed[True-False-True-False-True] 72.4810μs 27.2679μs 36.6731 KOps/s 34.6547 KOps/s $\textbf{\color{#35bf28}+5.82\%}$
test_step_mdp_speed[True-False-True-False-False] 44.6600μs 16.3073μs 61.3221 KOps/s 58.6619 KOps/s $\color{#35bf28}+4.53\%$
test_step_mdp_speed[True-False-False-True-True] 0.1122ms 51.6623μs 19.3565 KOps/s 18.3044 KOps/s $\textbf{\color{#35bf28}+5.75\%}$
test_step_mdp_speed[True-False-False-True-False] 77.1010μs 32.1743μs 31.0807 KOps/s 29.0031 KOps/s $\textbf{\color{#35bf28}+7.16\%}$
test_step_mdp_speed[True-False-False-False-True] 63.5310μs 30.1516μs 33.1657 KOps/s 31.6214 KOps/s $\color{#35bf28}+4.88\%$
test_step_mdp_speed[True-False-False-False-False] 68.0910μs 19.0503μs 52.4927 KOps/s 50.5283 KOps/s $\color{#35bf28}+3.89\%$
test_step_mdp_speed[False-True-True-True-True] 85.7110μs 50.2025μs 19.9193 KOps/s 19.2986 KOps/s $\color{#35bf28}+3.22\%$
test_step_mdp_speed[False-True-True-True-False] 61.9310μs 29.9496μs 33.3894 KOps/s 31.7196 KOps/s $\textbf{\color{#35bf28}+5.26\%}$
test_step_mdp_speed[False-True-True-False-True] 2.4077ms 32.0995μs 31.1531 KOps/s 30.8699 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-True-True-False-False] 43.8210μs 18.1713μs 55.0318 KOps/s 53.2811 KOps/s $\color{#35bf28}+3.29\%$
test_step_mdp_speed[False-True-False-True-True] 89.6110μs 53.0323μs 18.8564 KOps/s 18.1019 KOps/s $\color{#35bf28}+4.17\%$
test_step_mdp_speed[False-True-False-True-False] 86.0920μs 32.6570μs 30.6213 KOps/s 29.2198 KOps/s $\color{#35bf28}+4.80\%$
test_step_mdp_speed[False-True-False-False-True] 83.5920μs 34.0889μs 29.3351 KOps/s 28.5259 KOps/s $\color{#35bf28}+2.84\%$
test_step_mdp_speed[False-True-False-False-False] 61.3310μs 20.9493μs 47.7344 KOps/s 46.4851 KOps/s $\color{#35bf28}+2.69\%$
test_step_mdp_speed[False-False-True-True-True] 94.1810μs 55.2019μs 18.1153 KOps/s 17.3839 KOps/s $\color{#35bf28}+4.21\%$
test_step_mdp_speed[False-False-True-True-False] 67.4110μs 35.7809μs 27.9479 KOps/s 27.6694 KOps/s $\color{#35bf28}+1.01\%$
test_step_mdp_speed[False-False-True-False-True] 62.9610μs 33.2169μs 30.1052 KOps/s 28.8588 KOps/s $\color{#35bf28}+4.32\%$
test_step_mdp_speed[False-False-True-False-False] 66.1310μs 20.7378μs 48.2212 KOps/s 46.4966 KOps/s $\color{#35bf28}+3.71\%$
test_step_mdp_speed[False-False-False-True-True] 89.9810μs 57.3365μs 17.4409 KOps/s 16.8863 KOps/s $\color{#35bf28}+3.28\%$
test_step_mdp_speed[False-False-False-True-False] 75.3310μs 38.4442μs 26.0117 KOps/s 24.8387 KOps/s $\color{#35bf28}+4.72\%$
test_step_mdp_speed[False-False-False-False-True] 87.4320μs 35.7213μs 27.9945 KOps/s 27.0776 KOps/s $\color{#35bf28}+3.39\%$
test_step_mdp_speed[False-False-False-False-False] 60.8510μs 23.2582μs 42.9955 KOps/s 41.4746 KOps/s $\color{#35bf28}+3.67\%$
test_values[generalized_advantage_estimate-True-True] 10.3751ms 10.0644ms 99.3601 Ops/s 98.3622 Ops/s $\color{#35bf28}+1.01\%$
test_values[vec_generalized_advantage_estimate-True-True] 19.8390ms 17.6290ms 56.7246 Ops/s 56.7507 Ops/s $\color{#d91a1a}-0.05\%$
test_values[td0_return_estimate-False-False] 0.2450ms 0.1306ms 7.6584 KOps/s 7.5296 KOps/s $\color{#35bf28}+1.71\%$
test_values[td1_return_estimate-False-False] 27.4971ms 27.2477ms 36.7004 Ops/s 36.4568 Ops/s $\color{#35bf28}+0.67\%$
test_values[vec_td1_return_estimate-False-False] 18.2274ms 17.7570ms 56.3159 Ops/s 56.3034 Ops/s $\color{#35bf28}+0.02\%$
test_values[td_lambda_return_estimate-True-False] 41.2961ms 40.6927ms 24.5744 Ops/s 24.5160 Ops/s $\color{#35bf28}+0.24\%$
test_values[vec_td_lambda_return_estimate-True-False] 18.1443ms 17.7526ms 56.3298 Ops/s 56.2839 Ops/s $\color{#35bf28}+0.08\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.8379ms 8.6325ms 115.8419 Ops/s 106.7015 Ops/s $\textbf{\color{#35bf28}+8.57\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.7211ms 1.5179ms 658.7951 Ops/s 664.1661 Ops/s $\color{#d91a1a}-0.81\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4594ms 0.4105ms 2.4360 KOps/s 2.4102 KOps/s $\color{#35bf28}+1.07\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 34.8457ms 34.2053ms 29.2352 Ops/s 28.6824 Ops/s $\color{#35bf28}+1.93\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 1.8556ms 1.7161ms 582.7153 Ops/s 577.3099 Ops/s $\color{#35bf28}+0.94\%$
test_dqn_speed[False-None] 6.4913ms 1.4099ms 709.2951 Ops/s 706.3539 Ops/s $\color{#35bf28}+0.42\%$
test_dqn_speed[False-backward] 1.9921ms 1.9226ms 520.1183 Ops/s 519.9475 Ops/s $\color{#35bf28}+0.03\%$
test_dqn_speed[True-None] 0.9081ms 0.5166ms 1.9357 KOps/s 1.9302 KOps/s $\color{#35bf28}+0.29\%$
test_dqn_speed[True-backward] 1.0154ms 0.9622ms 1.0393 KOps/s 1.0282 KOps/s $\color{#35bf28}+1.08\%$
test_dqn_speed[reduce-overhead-None] 0.7156ms 0.5083ms 1.9675 KOps/s 1.8748 KOps/s $\color{#35bf28}+4.94\%$
test_dqn_speed[reduce-overhead-backward] 0.9954ms 0.9586ms 1.0432 KOps/s 1.0418 KOps/s $\color{#35bf28}+0.13\%$
test_ddpg_speed[False-None] 3.1661ms 2.8663ms 348.8772 Ops/s 343.4413 Ops/s $\color{#35bf28}+1.58\%$
test_ddpg_speed[False-backward] 4.2442ms 4.0952ms 244.1863 Ops/s 244.6722 Ops/s $\color{#d91a1a}-0.20\%$
test_ddpg_speed[True-None] 1.7612ms 1.3828ms 723.1590 Ops/s 714.4010 Ops/s $\color{#35bf28}+1.23\%$
test_ddpg_speed[True-backward] 2.3928ms 2.3423ms 426.9353 Ops/s 363.3271 Ops/s $\textbf{\color{#35bf28}+17.51\%}$
test_ddpg_speed[reduce-overhead-None] 1.7708ms 1.3749ms 727.3377 Ops/s 721.0364 Ops/s $\color{#35bf28}+0.87\%$
test_ddpg_speed[reduce-overhead-backward] 2.4046ms 2.3357ms 428.1321 Ops/s 381.4742 Ops/s $\textbf{\color{#35bf28}+12.23\%}$
test_sac_speed[False-None] 8.4291ms 7.9765ms 125.3678 Ops/s 125.0857 Ops/s $\color{#35bf28}+0.23\%$
test_sac_speed[False-backward] 11.8418ms 11.3593ms 88.0339 Ops/s 88.5549 Ops/s $\color{#d91a1a}-0.59\%$
test_sac_speed[True-None] 2.3645ms 2.2585ms 442.7685 Ops/s 439.5022 Ops/s $\color{#35bf28}+0.74\%$
test_sac_speed[True-backward] 4.2654ms 4.1393ms 241.5870 Ops/s 223.4296 Ops/s $\textbf{\color{#35bf28}+8.13\%}$
test_sac_speed[reduce-overhead-None] 2.6328ms 2.2533ms 443.7883 Ops/s 424.3826 Ops/s $\color{#35bf28}+4.57\%$
test_sac_speed[reduce-overhead-backward] 4.3191ms 4.1736ms 239.5987 Ops/s 237.2695 Ops/s $\color{#35bf28}+0.98\%$
test_redq_speed[False-None] 10.7513ms 10.2308ms 97.7440 Ops/s 94.4732 Ops/s $\color{#35bf28}+3.46\%$
test_redq_speed[False-backward] 23.5333ms 17.9609ms 55.6764 Ops/s 54.6163 Ops/s $\color{#35bf28}+1.94\%$
test_redq_speed[True-None] 4.5388ms 4.3410ms 230.3615 Ops/s 221.0758 Ops/s $\color{#35bf28}+4.20\%$
test_redq_speed[True-backward] 10.1059ms 9.8689ms 101.3285 Ops/s 96.0792 Ops/s $\textbf{\color{#35bf28}+5.46\%}$
test_redq_speed[reduce-overhead-None] 4.4130ms 4.2434ms 235.6574 Ops/s 228.9928 Ops/s $\color{#35bf28}+2.91\%$
test_redq_speed[reduce-overhead-backward] 10.3570ms 9.8923ms 101.0883 Ops/s 96.0004 Ops/s $\textbf{\color{#35bf28}+5.30\%}$
test_redq_deprec_speed[False-None] 11.4443ms 11.0275ms 90.6825 Ops/s 91.7976 Ops/s $\color{#d91a1a}-1.21\%$
test_redq_deprec_speed[False-backward] 16.5796ms 16.1368ms 61.9702 Ops/s 64.4800 Ops/s $\color{#d91a1a}-3.89\%$
test_redq_deprec_speed[True-None] 4.4857ms 4.2972ms 232.7114 Ops/s 234.1645 Ops/s $\color{#d91a1a}-0.62\%$
test_redq_deprec_speed[True-backward] 8.5342ms 8.3746ms 119.4083 Ops/s 109.5868 Ops/s $\textbf{\color{#35bf28}+8.96\%}$
test_redq_deprec_speed[reduce-overhead-None] 4.4541ms 4.2625ms 234.6035 Ops/s 230.6501 Ops/s $\color{#35bf28}+1.71\%$
test_redq_deprec_speed[reduce-overhead-backward] 8.7218ms 8.4028ms 119.0084 Ops/s 115.2107 Ops/s $\color{#35bf28}+3.30\%$
test_td3_speed[False-None] 8.3236ms 7.9461ms 125.8479 Ops/s 124.7421 Ops/s $\color{#35bf28}+0.89\%$
test_td3_speed[False-backward] 11.1774ms 10.8083ms 92.5217 Ops/s 92.4754 Ops/s $\color{#35bf28}+0.05\%$
test_td3_speed[True-None] 1.8166ms 1.7727ms 564.1263 Ops/s 555.2606 Ops/s $\color{#35bf28}+1.60\%$
test_td3_speed[True-backward] 3.7362ms 3.6170ms 276.4750 Ops/s 228.9588 Ops/s $\textbf{\color{#35bf28}+20.75\%}$
test_td3_speed[reduce-overhead-None] 1.8069ms 1.7441ms 573.3461 Ops/s 540.0737 Ops/s $\textbf{\color{#35bf28}+6.16\%}$
test_td3_speed[reduce-overhead-backward] 3.7239ms 3.6361ms 275.0232 Ops/s 270.5205 Ops/s $\color{#35bf28}+1.66\%$
test_cql_speed[False-None] 30.2207ms 26.0527ms 38.3837 Ops/s 38.9013 Ops/s $\color{#d91a1a}-1.33\%$
test_cql_speed[False-backward] 39.7105ms 35.3882ms 28.2580 Ops/s 28.5608 Ops/s $\color{#d91a1a}-1.06\%$
test_cql_speed[True-None] 12.4991ms 12.1985ms 81.9776 Ops/s 79.1895 Ops/s $\color{#35bf28}+3.52\%$
test_cql_speed[True-backward] 18.5914ms 18.2046ms 54.9311 Ops/s 53.7325 Ops/s $\color{#35bf28}+2.23\%$
test_cql_speed[reduce-overhead-None] 13.1326ms 12.4992ms 80.0050 Ops/s 81.9147 Ops/s $\color{#d91a1a}-2.33\%$
test_cql_speed[reduce-overhead-backward] 18.7011ms 18.1765ms 55.0161 Ops/s 57.3751 Ops/s $\color{#d91a1a}-4.11\%$
test_a2c_speed[False-None] 5.6258ms 5.3786ms 185.9205 Ops/s 183.0509 Ops/s $\color{#35bf28}+1.57\%$
test_a2c_speed[False-backward] 12.1462ms 11.8351ms 84.4941 Ops/s 84.0870 Ops/s $\color{#35bf28}+0.48\%$
test_a2c_speed[True-None] 3.9454ms 3.7228ms 268.6117 Ops/s 267.8202 Ops/s $\color{#35bf28}+0.30\%$
test_a2c_speed[True-backward] 8.8577ms 8.6174ms 116.0443 Ops/s 115.0969 Ops/s $\color{#35bf28}+0.82\%$
test_a2c_speed[reduce-overhead-None] 3.8416ms 3.6918ms 270.8689 Ops/s 272.2159 Ops/s $\color{#d91a1a}-0.49\%$
test_a2c_speed[reduce-overhead-backward] 9.0292ms 8.7006ms 114.9344 Ops/s 113.2062 Ops/s $\color{#35bf28}+1.53\%$
test_ppo_speed[False-None] 6.0856ms 5.9353ms 168.4841 Ops/s 169.5609 Ops/s $\color{#d91a1a}-0.64\%$
test_ppo_speed[False-backward] 12.8588ms 12.5631ms 79.5981 Ops/s 79.7162 Ops/s $\color{#d91a1a}-0.15\%$
test_ppo_speed[True-None] 3.7341ms 3.6198ms 276.2575 Ops/s 263.0290 Ops/s $\textbf{\color{#35bf28}+5.03\%}$
test_ppo_speed[True-backward] 11.2139ms 8.8673ms 112.7739 Ops/s 114.5405 Ops/s $\color{#d91a1a}-1.54\%$
test_ppo_speed[reduce-overhead-None] 3.7404ms 3.6141ms 276.6920 Ops/s 270.9342 Ops/s $\color{#35bf28}+2.13\%$
test_ppo_speed[reduce-overhead-backward] 8.8463ms 8.6215ms 115.9893 Ops/s 112.6517 Ops/s $\color{#35bf28}+2.96\%$
test_reinforce_speed[False-None] 4.9333ms 4.5826ms 218.2146 Ops/s 214.9172 Ops/s $\color{#35bf28}+1.53\%$
test_reinforce_speed[False-backward] 7.6003ms 7.3547ms 135.9680 Ops/s 133.0989 Ops/s $\color{#35bf28}+2.16\%$
test_reinforce_speed[True-None] 3.0769ms 2.8194ms 354.6848 Ops/s 343.0876 Ops/s $\color{#35bf28}+3.38\%$
test_reinforce_speed[True-backward] 7.8142ms 7.6096ms 131.4123 Ops/s 128.9788 Ops/s $\color{#35bf28}+1.89\%$
test_reinforce_speed[reduce-overhead-None] 3.2387ms 2.8306ms 353.2792 Ops/s 345.5730 Ops/s $\color{#35bf28}+2.23\%$
test_reinforce_speed[reduce-overhead-backward] 8.4307ms 7.8487ms 127.4100 Ops/s 125.9757 Ops/s $\color{#35bf28}+1.14\%$
test_iql_speed[False-None] 20.2434ms 19.5159ms 51.2403 Ops/s 48.6359 Ops/s $\textbf{\color{#35bf28}+5.35\%}$
test_iql_speed[False-backward] 31.1404ms 30.2054ms 33.1066 Ops/s 31.7389 Ops/s $\color{#35bf28}+4.31\%$
test_iql_speed[True-None] 9.1192ms 8.5164ms 117.4200 Ops/s 111.3586 Ops/s $\textbf{\color{#35bf28}+5.44\%}$
test_iql_speed[True-backward] 17.0277ms 16.7299ms 59.7733 Ops/s 58.1471 Ops/s $\color{#35bf28}+2.80\%$
test_iql_speed[reduce-overhead-None] 8.8499ms 8.5613ms 116.8042 Ops/s 113.9911 Ops/s $\color{#35bf28}+2.47\%$
test_iql_speed[reduce-overhead-backward] 18.6844ms 17.1774ms 58.2161 Ops/s 56.0740 Ops/s $\color{#35bf28}+3.82\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.6475ms 6.1045ms 163.8148 Ops/s 166.0660 Ops/s $\color{#d91a1a}-1.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5464s 0.7965ms 1.2556 KOps/s 3.1746 KOps/s $\textbf{\color{#d91a1a}-60.45\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5294ms 0.3421ms 2.9233 KOps/s 3.4211 KOps/s $\textbf{\color{#d91a1a}-14.55\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.2686ms 5.7426ms 174.1374 Ops/s 173.0564 Ops/s $\color{#35bf28}+0.62\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6813ms 0.3254ms 3.0733 KOps/s 3.0690 KOps/s $\color{#35bf28}+0.14\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4866ms 0.2640ms 3.7876 KOps/s 2.7664 KOps/s $\textbf{\color{#35bf28}+36.92\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5765ms 1.3535ms 738.8144 Ops/s 710.2210 Ops/s $\color{#35bf28}+4.03\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5517ms 1.2818ms 780.1755 Ops/s 834.1305 Ops/s $\textbf{\color{#d91a1a}-6.47\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.9200ms 5.9907ms 166.9263 Ops/s 167.2554 Ops/s $\color{#d91a1a}-0.20\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.7878ms 0.4808ms 2.0797 KOps/s 2.1246 KOps/s $\color{#d91a1a}-2.11\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7411ms 0.5078ms 1.9692 KOps/s 2.2265 KOps/s $\textbf{\color{#d91a1a}-11.56\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.1728ms 5.7964ms 172.5213 Ops/s 170.6469 Ops/s $\color{#35bf28}+1.10\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6736ms 0.3150ms 3.1750 KOps/s 2.8817 KOps/s $\textbf{\color{#35bf28}+10.18\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4759ms 0.2665ms 3.7524 KOps/s 3.3491 KOps/s $\textbf{\color{#35bf28}+12.04\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.8177ms 5.7705ms 173.2949 Ops/s 173.9464 Ops/s $\color{#d91a1a}-0.37\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.6488ms 0.2954ms 3.3856 KOps/s 3.5554 KOps/s $\color{#d91a1a}-4.78\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5416ms 0.3374ms 2.9635 KOps/s 2.9309 KOps/s $\color{#35bf28}+1.11\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3070ms 5.9229ms 168.8362 Ops/s 167.0213 Ops/s $\color{#35bf28}+1.09\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.0040ms 0.4439ms 2.2527 KOps/s 1.9950 KOps/s $\textbf{\color{#35bf28}+12.92\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.5974ms 0.4135ms 2.4186 KOps/s 2.1238 KOps/s $\textbf{\color{#35bf28}+13.88\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.6732ms 5.0728ms 197.1302 Ops/s 192.9100 Ops/s $\color{#35bf28}+2.19\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 10.5303ms 2.2024ms 454.0593 Ops/s 486.2932 Ops/s $\textbf{\color{#d91a1a}-6.63\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2043ms 1.0816ms 924.5918 Ops/s 832.0025 Ops/s $\textbf{\color{#35bf28}+11.13\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 8.0161ms 5.1779ms 193.1282 Ops/s 192.8771 Ops/s $\color{#35bf28}+0.13\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.4612s 11.1928ms 89.3429 Ops/s 491.1067 Ops/s $\textbf{\color{#d91a1a}-81.81\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.3157ms 1.1989ms 834.1015 Ops/s 828.8808 Ops/s $\color{#35bf28}+0.63\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 7.5551ms 5.3141ms 188.1798 Ops/s 58.3532 Ops/s $\textbf{\color{#35bf28}+222.48\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 9.1571ms 2.2203ms 450.3956 Ops/s 562.8683 Ops/s $\textbf{\color{#d91a1a}-19.98\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.7216ms 1.3833ms 722.9276 Ops/s 735.2248 Ops/s $\color{#d91a1a}-1.67\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 36.6685ms 34.0916ms 29.3328 Ops/s 28.8956 Ops/s $\color{#35bf28}+1.51\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.5843ms 17.9570ms 55.6885 Ops/s 54.5981 Ops/s $\color{#35bf28}+2.00\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 37.6211ms 35.1216ms 28.4725 Ops/s 27.6701 Ops/s $\color{#35bf28}+2.90\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 18.9641ms 17.6028ms 56.8093 Ops/s 53.8776 Ops/s $\textbf{\color{#35bf28}+5.44\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 39.0657ms 36.3281ms 27.5269 Ops/s 26.6054 Ops/s $\color{#35bf28}+3.46\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.5253ms 18.9770ms 52.6955 Ops/s 51.0296 Ops/s $\color{#35bf28}+3.26\%$

@vmoens vmoens force-pushed the fixes branch 2 times, most recently from 0bc8ed6 to 2e73a09 Compare November 10, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens