Skip to content

[BE] Improve logging for regression report lambda #7375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[BE] Improve logging for regression report lambda #7375

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d932411
add config
yangw-dev Oct 17, 2025
ac0c941
add config
yangw-dev Oct 17, 2025
ff777c7
add config
yangw-dev Oct 17, 2025
30e7536
add config
yangw-dev Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions aws/lambda/benchmark_regression_summary_report/lambda_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,17 @@ def process(
target, ls, le = self.get_target(config, self.end_time)
if not target:
self.log_info(
f"no target data found for time range [{ls},{le}] with frequency {report_freq.get_text()}..."
"skip generate report. no target data found"
f"for time range [{format_ts_with_t(ls)},{format_ts_with_t(le)}]"
f"with frequency {report_freq.get_text()}..."
)
return
baseline, bs, be = self.get_baseline(config, self.end_time)
if not baseline:
self.log_info(
f"no baseline data found for time range [{bs},{be}] with frequency {report_freq.get_text()}..."
"skip generate report. no baseline data found for"
f"time range[{format_ts_with_t(bs)},{format_ts_with_t(be)}]"
f"with frequency {report_freq.get_text()}..."
)
return
generator = BenchmarkRegressionReportGenerator(
Expand All @@ -169,7 +173,7 @@ def get_target(self, config: BenchmarkConfig, end_time: int):
target_s = end_time - data_range.comparison_timedelta_s()
target_e = end_time
self.log_info(
"getting target data for time range "
"getting target data (newest) for time range "
f"[{format_ts_with_t(target_s)},{format_ts_with_t(target_e)}] ..."
)
target_data = self._fetch_from_benchmark_ts_api(
Expand All @@ -179,7 +183,9 @@ def get_target(self, config: BenchmarkConfig, end_time: int):
source=config.source,
)
self.log_info(
f"done. found {len(target_data.time_series)} # of data groups, with time range {target_data.time_range}",
"Done fetching target data (newest)."
f"found {len(target_data.time_series)} # of groups,"
f"with time range {target_data.time_range}",
)
if not target_data.time_range or not target_data.time_range.end:
return None, target_s, target_e
Expand All @@ -206,7 +212,9 @@ def get_baseline(self, config: BenchmarkConfig, end_time: int):
)

self.log_info(
f"Done. found {len(raw_data.time_series)} # of data, with time range {raw_data.time_range}",
"Done fetching baseline data."
f"found {len(raw_data.time_series)} # of data,"
f"with time range {raw_data.time_range}"
)

baseline_latest_ts = int(isoparse(raw_data.time_range.end).timestamp())
Expand Down Expand Up @@ -236,7 +244,9 @@ def should_use_data(

if latest_ts >= cutoff:
return True
self.log_info(f"expect latest data to be after {cutoff}, but got {latest_ts}")
self.log_info(
f"expect latest data to be after unixtime {format_ts_with_t(cutoff)}, but got {format_ts_with_t(latest_ts)}"
)
return False

def _fetch_from_benchmark_ts_api(
Expand Down