[CLEAN] Synthetic Benchmark PR #19307 - Remove deprecated code Runner functionality and system Blocks
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerqodo
pushed a commit
that referenced
this pull request
Nov 24, 2025
…ne serialization this commit addresses alex's PR review comments #1-4: 1. keep all inputs including reserved keywords (like 'requires') in event payload 2. use get_events_client() with checkpoint_every=1 directly instead of emit_event to avoid buffering issues (similar to Runner heartbeat pattern) 3. pass flow_run and logger as params instead of relying on context 4. inline serialization logic directly in run_steps loop instead of separate function also converts all event-related tests to use AssertingEventsClient fixture pattern instead of custom fake clients, which required using the events client as an async context manager. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
tomerqodo
pushed a commit
that referenced
this pull request
Nov 24, 2025
…ne serialization This commit addresses PR review comments #1-4 and implements the requested change from comment #5: 1. Keep reserved keywords (like 'requires') in serialized inputs ✅ 2. Use `get_events_client(checkpoint_every=1)` directly instead of `emit_event` to avoid buffering issues ✅ 3. Pass `flow_run` and `logger` as parameters instead of using context ✅ 4. Inline step serialization logic directly in `run_steps` ✅ 5. Emit **one event per step** instead of one aggregate event ✅ Changes: - Removed `_EnvironmentRunContext` class and tests (over-engineered) - Read `flow_run_id` directly from `os.getenv("PREFECT__FLOW_RUN_ID")` - Changed from single aggregate event to individual events per step: - `prefect.flow-run.pull-step.executed` for each successful step - `prefect.flow-run.pull-step.failed` when a step fails - Updated all tests to expect one event per step - Event payload now contains individual step data (index, qualified_name, step_name, id, inputs) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR PrefectHQ#19307
Type: Clean (correct implementation)
Original PR Title: Remove deprecated code
Runnerfunctionality and system BlocksOriginal PR Description: ## Summary
This PR removes all deprecated code from core Prefect that has reached or passed its scheduled removal date.
Changes
Removed Blocks
src/prefect/blocks/system.pyRemoved Functions
ResultStore.store_parameters() and read_parameters() (deprecated May 2025, removal date November 2025)
prefect.task_workermodulebuild_server() and start_webserver() from runner.server (deprecated April 2025, removal date October 2025)
.serve()methodsubmit_to_runner() and wait_for_submitted_runs() from runner.submit (deprecated April 2025, removal date October 2025)
run_deployment()DeploymentClient.set_deployment_paused_state() sync and async (deprecated June 2025, removal date December 2025)
pause_deployment()andresume_deployment()methodsRemoved CLI Commands
prefect cloud open(deprecated October 2024, removal date April 2025)prefect dashboard openOther Updates
Impact
🤖 Generated with Claude Code
Original PR URL: PrefectHQ#19307