Fix exception rethrow in tool executor #1904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
approved these changes
Oct 29, 2025
jmartisk
reviewed
Oct 29, 2025
| invokerClassName, methodCreateInfo.methodName(), | ||
| methodCreateInfo.argumentMapperClassName(), methodCreateInfo.executionModel(), | ||
| methodCreateInfo.returnBehavior()); | ||
| methodCreateInfo.returnBehavior(), false); |
Collaborator
There was a problem hiding this comment.
I guess this should be configurable, not just hardcoded to false. But that's something I can have a look at in a subsequent PR, so no worries.
jmartisk
approved these changes
Oct 29, 2025
Status for workflow
|
Collaborator
|
Heads up: I am going to align with upstream LangChain4j on error handling with #2014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went with the example I posted in the issue's thread, this is to maintain the framework's error as properly propagated while not rethrowing exceptions defined by users in their tools.