feat: Add cached size to internal nodes #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@qwertie fyi I'm splitting this out from #48 as it is the only change to the core BTree and I assume you'll want to review (I can have my team review the other non-core changes). There aren't additional tests here because all calls to checkValid now check the size caching, and the (wildly) robust fuzz tests in #48 cover it. |
Collaborator
Author
|
@qwertie are you okay if I merge this? Anything you'd like to see changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cached size field to all internal nodes and updates it as appropriate. This change is a precursor to the set operations PR (#48) and is required to do such bulk operations in sub-linear time.
As part of this PR, the check valid method was enhanced and made more robust to ensure the cached size is correct (some of the logic is more useful for validating set operations, and was pulled out of that PR).