Skip to content

feat(support-gujarati) : supports gujarati langugae translations in nixopus #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(support-gujarati) : supports gujarati langugae translations in nixopus #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions view/lib/i18n/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
export const defaultLocale = 'en';
export const locales = ['en', 'es', 'fr', 'kn', 'ml'] as const;
export const locales = ['en', 'es', 'fr', 'kn', 'ml', 'gu'] as const;
export type Locale = (typeof locales)[number];

export const languageNames: Record<Locale, string> = {
en: 'English',
es: 'Español',
fr: 'Français',
kn: 'ಕನ್ನಡ',
ml: 'മലയാളം'
ml: 'മലയാളം',
gu: 'ગુજરાતી'
};
3 changes: 2 additions & 1 deletion view/lib/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,8 @@
"es": "Spanish",
"fr": "French",
"kn": "Kannada",
"ml": "Malayalam"
"ml": "Malayalam",
"gu": "Gujarati"
},
"dashboard": {
"title": "Dashboard",
Expand Down
3 changes: 2 additions & 1 deletion view/lib/i18n/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,8 @@
"es": "Español",
"fr": "Francés",
"kn": "Canarés",
"ml": "Malayalam"
"ml": "Malayalam",
"gu": "Gujarati"
},
"dashboard": {
"title": "Panel de control",
Expand Down
3 changes: 2 additions & 1 deletion view/lib/i18n/locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,8 @@
"es": "Espagnol",
"fr": "Français",
"kn": "Kannada",
"ml": "Malayalam"
"ml": "Malayalam",
"gu": "Gujarati"
},
"dashboard": {
"title": "Tableau de bord",
Expand Down
1,432 changes: 1,432 additions & 0 deletions view/lib/i18n/locales/gu.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion view/lib/i18n/locales/kn.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,8 @@
"es": "ಸ್ಪ್ಯಾನಿಷ್",
"fr": "ಫ್ರೆಂಚ್",
"kn": "ಕನ್ನಡ",
"ml": "ಮಲಯಾಳಂ"
"ml": "ಮಲಯಾಳಂ",
"gu": "ಗುಜರಾತಿ"
},
"dashboard": {
"title": "ಡ್ಯಾಶ್ಬೋರ್ಡ್",
Expand Down
3 changes: 2 additions & 1 deletion view/lib/i18n/locales/ml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,8 @@
"es": "സ്പാനിഷ്",
"fr": "ഫ്രഞ്ച്",
"kn": "കന്നഡ",
"ml": "മലയാളം"
"ml": "മലയാളം",
"gu": "ഗുജറാത്തി"
},
Comment on lines +764 to 766
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Do not translate interpolation tokens like {count}/{value}/{name}

Spotted localized placeholders (e.g., "+{എണ്ണുക} കൂടുതൽ", "{മൂല്യം}", "{പേര്}"), which will break runtime interpolation. Keep the identifiers exactly as in en.json.

Run a quick check to find translated tokens:

Also applies to: 68-69, 782-791, 689-692

🏁 Script executed:

#!/bin/bash
rg -nP '\{[^}]+\}' view/lib/i18n/locales/ml.json | sed -n '1,200p'

Length of output: 1321

I need to check the English version to confirm the correct placeholder format and whether this is a pre-existing issue or newly introduced:

Let me check the specific lines being changed and compare with en.json:

Fix translated placeholder identifiers preventing runtime interpolation

The ml.json file contains translated placeholder identifiers in interpolation strings (lines 68, 689-690, 782, 788-790, 817-819, 863, 915-916, 949, 1110-1111, 1141, 1320) that will break runtime interpolation. Placeholder identifiers must use named placeholders and cannot be translated—they need to remain language-independent as {count}, {name}, {value}, etc.

Examples requiring fixes:

  • Line 68: "+{എണ്ണുക} കൂടുതൽ" → "+{count} കൂടുതൽ"
  • Line 689-690: "{പേര്}" → "{name}"
  • Line 782: "+{എണ്ണുക} കൂടുതൽ" → "+{count} കൂടുതൽ"
  • Line 788-790, 817-819: "{മൂല്യം}" → "{value}"

Update all translated placeholder names back to their English equivalents.

Copy link
Author

@ashwintemkar ashwintemkar Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not done by me as this seems to be irrelevant to my commit pushed,

it has been there since the Malayalam language addition,

@raghavyuva let me know if this is necessary, if yes I will change that too, otherwise I will let it go as it is not from my push or fix it if y'all need it to be correct what someone else had pushed

Copy link
Contributor

@coderabbitai coderabbitai bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

"dashboard": {
"title": "ഡാഷ്ബോർഡ്",
Expand Down