feat: enable skip select namespaces in useStatefulConnect hook #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyukTheCoder
force-pushed
the
feat/rf-2729-enable-skip-select-namespaces-in-use-stateful-connect
branch
from
ae9f0b7 to
5a9a7c8
Compare
RyukTheCoder
force-pushed
the
feat/rf-2729-enable-skip-select-namespaces-in-use-stateful-connect
branch
from
5a9a7c8 to
d7a4afc
Compare
RyukTheCoder
force-pushed
the
feat/rf-2729-enable-skip-select-namespaces-in-use-stateful-connect
branch
from
d7a4afc to
a6e1484
Compare
yeager-eren
requested changes
Oct 29, 2025
| path: string | ||
| path: string, | ||
| options?: { | ||
| forcedNamespaces?: Namespace[]; |
Collaborator
There was a problem hiding this comment.
let's call the option: onlyConnectTo or forceConnectTo.
Contributor
Author
There was a problem hiding this comment.
Changed to forceConnectToNamespaces. I think its better to keep namespaces in the naming.
| : 'An unknown error happened during connecting wallet.'; | ||
|
|
||
| if (options?.disconnectOnError) { | ||
| await handleDisconnect(wallet); |
Collaborator
There was a problem hiding this comment.
this may throw an error itself, you need to do something like L86 for .catch here as well.
Contributor
Author
There was a problem hiding this comment.
As the only important error here is the error related to connecting the wallet, added a try/catch around the disconnect to warn the error related to disconnecting wallet in the console.
yeager-eren
force-pushed
the
next
branch
2 times, most recently
from
9431967 to
6507542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, initial and detached modals get displayed when user tries to connect a hub wallet. In this PR, a
forcedNamespacesparameter is added tohandleConnectmethod ofuseStatefulConnecthook to enable selecting some namespaces programmatically without displaying initial and detached modal. So whenhandleConnectgets called with someforcedNamespaces, those namespaces get connected and if one of them get an error, all of them get disconnected.How did you test this change?
Tested by linking this PR to app and passed
SolanaandEVMnamespaces asskipSelectNamespacesand observed the required behavior.Checklist: