UMAP with int64_t spectral initialization
#7224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aamijar
added
non-breaking
This PR changes two things: 1. Removes dependency on `libcuvs` for wheel builds, as we clone and build from source to facilitate static link 2. Removes dependency on `cuvs` for all builds Authors: - Divye Gala (https://github.com/divyegala) - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Simon Adorf (https://github.com/csadorf) URL: rapidsai#7261
Contributor
|
@aamijar Should this be moved to 25.12? |
Member
Author
|
Yes, I guess the github issue was in 25.12, but the PR still says 25.10. Changed it now |
Closes rapidsai#6539 ~Requires rapidsai/raft#2739 This PR: - Trims the graph before embedding initialization - Stores the graph on host when using the UMAP estimator Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Jinsol Park (https://github.com/jinsolp) - Divye Gala (https://github.com/divyegala) URL: rapidsai#6595
This makes use of the `CUML_ACCEL_ENABLED` environment variable to ensure if cuml.accel is enabled in a parent process then it's enabled (by default) in a child process. This makes `cuml.accel` usage more transparent with common python multiprocessing solutions (`multiprocessing`/`joblib`/`dask`). Things _just work_. Currently on top of rapidsai#7046. Note that this use case was the primary motivation for rapidsai#7046, though I can see other reasons why an environment variable might be nice too. Authors: - Jim Crist-Harif (https://github.com/jcrist) - Simon Adorf (https://github.com/csadorf) Approvers: - Simon Adorf (https://github.com/csadorf) URL: rapidsai#7047
Contributor
|
@aamijar This is still targeting the 25.10 branch. |
Member
Author
|
Changed target branch now |
Member
Author
|
Approach has been updated, new PR will be created for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7225; Depends on rapidsai/raft#2793 and rapidsai/cuvs#1302
For larger datasets UMAP dispatches a COO matrix with
uint64_tnnz template types. This PR add support to correctly forward this template type to spectral initialization.