Skip to content

Conversation

@vardhan30016
Copy link

@vardhan30016 vardhan30016 commented Oct 31, 2025

Summary

This PR implements the adjusted_mutual_info_score metric in cuML’s cluster metrics module.
It mirrors the scikit-learn API for consistent behavior and prepares for future GPU acceleration.

Related Issue

Fixes: #7294

Implementation Details

  • Added new file: python/cuml/metrics/cluster/adjusted_mutual_info_score.py
  • Updated __init__.py to expose the new metric
  • Added docstring with parameters and return type
  • Uses sklearn’s implementation internally for now (compatibility wrapper)

Checklist

  • Code builds locally
  • Unit tested manually
  • Follows cuML’s code style
  • Linked to the corresponding issue

Author: Vardhan Naidu (@vardhan30016)

@vardhan30016 vardhan30016 requested a review from a team as a code owner October 31, 2025 11:10
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 31, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 31, 2025
@csadorf csadorf changed the title ENH: Add adjusted_mutual_info_score metric (implements AMI) (fixes #7… ENH: Add adjusted_mutual_info_score metric Oct 31, 2025
@csadorf csadorf added feature request New feature or request non-breaking Non-breaking change labels Nov 3, 2025
@vardhan30016 vardhan30016 requested a review from a team as a code owner November 6, 2025 19:37
@vardhan30016 vardhan30016 force-pushed the feature/adjusted_mutual_info_score branch from 47e295e to 325fb22 Compare November 7, 2025 04:47
@vardhan30016 vardhan30016 requested review from a team as code owners November 7, 2025 04:47
@vardhan30016 vardhan30016 requested a review from bdice November 7, 2025 04:47
@github-actions github-actions bot added ci and removed CUDA/C++ ci labels Nov 7, 2025
@vardhan30016 vardhan30016 force-pushed the feature/adjusted_mutual_info_score branch from 77d5494 to 88da3ce Compare November 12, 2025 14:04
@vardhan30016
Copy link
Author

Rebased this branch with the latest main and force-pushed to update the commit history.
All local tests pass successfully, and the CI should now rerun with the latest base.

The implementation for adjusted_mutual_info_score is stable and aligned with scikit-learn’s behavior.

@bdice @csadorf @divyegala — please review when convenient. Thanks for your guidance and feedback!

@csadorf
Copy link
Contributor

csadorf commented Nov 12, 2025

Have a look at the diff and commits on this PR, something must have gone wrong with the rebase.

@csadorf csadorf force-pushed the feature/adjusted_mutual_info_score branch from 88da3ce to 1e7eb53 Compare November 17, 2025 18:05
@csadorf csadorf removed request for a team November 17, 2025 18:06
@csadorf
Copy link
Contributor

csadorf commented Nov 17, 2025

This PR has significant file organization issues that need cleanup. The same code appears multiple times across different files - including files with invalid extensions like .pyes and .p, files in the repository root that should be in proper package locations, and test files in both correct and incorrect directories. There are also empty placeholder files and an __init__.py marked as new but containing comments like # existing imports... suggesting it should be modifying an existing file instead.

The PR also includes both a CPU-based sklearn wrapper and a separate GPU implementation without clarity on which is intended or how they integrate. Given the extent of cleanup needed, I'm going to close this PR. Please open a new PR with only the necessary files in their correct locations and a clear implementation approach.

@csadorf csadorf closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Implement adjusted_mutual_info_score

2 participants