feat(workflow-list): add more pagination size options #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbuchar
pushed a commit
to michaelbuchar/reana-ui
that referenced
this pull request
Oct 22, 2025
- Replaced native select with Semantic UI Dropdown - Updated default page size from 5 to 10 - Pagination and results per page dropdown aligned on same row - Added new SCSS styles - Removed unnecessary overflow in WorkflowSharingFilter style
michaelbuchar
force-pushed
the
feat/customize-pagination
branch
from
a06c62c to
691682c
Compare
michaelbuchar
changed the title
Author
|
First, we need to merge #440 and then we can merge this PR |
michaelbuchar
changed the title
Member
|
The commitlint is failing because the commit body is a list instead of a paragraph with full stops. I prefer the list for readability, but I think we want it in a paragraph for consistency with the other commits. We can have the bullet points in the PR description though ofc as you have now. |
Member
|
Out of interest, what is the convention when one PR depends on another PR, like this? Do you keep it in draft and have some 'depends on' note in the description? Or do you open a PR to merge into the 'parent' branch instead of into master? Or something else? |
michaelbuchar
force-pushed
the
feat/customize-pagination
branch
4 times, most recently
from
b187916 to
5657e21
Compare
michaelbuchar
pushed a commit
to michaelbuchar/reana-ui
that referenced
this pull request
Nov 19, 2025
- Replaced native select with Semantic UI Dropdown - Updated default page size from 5 to 10 - Pagination and results per page dropdown aligned on same row - Added new SCSS styles - Removed unnecessary overflow in WorkflowSharingFilter style
michaelbuchar
force-pushed
the
feat/customize-pagination
branch
from
5657e21 to
28a9d64
Compare
Member
tiborsimko
reviewed
Nov 19, 2025
tiborsimko
reviewed
Nov 19, 2025
Author
Member
CameronMcClymont
left a comment
CameronMcClymont
left a comment
There was a problem hiding this comment.
Cleeeaan code as usual 🧼🫧😍
- Replaced native select with Semantic UI Dropdown - Updated default page size from 5 to 10 - Pagination and results per page dropdown aligned on same row - Added new SCSS styles - Removed unnecessary overflow in WorkflowSharingFilter style
michaelbuchar
force-pushed
the
feat/customize-pagination
branch
from
28a9d64 to
a510331
Compare
CameronMcClymont
approved these changes
Nov 20, 2025
tiborsimko
changed the title
tiborsimko
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.