-
Notifications
You must be signed in to change notification settings - Fork 315
KFLUXINFRA-2633: PenTest Cluster's removal #9423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: celeztyne The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🤖 Gemini AI Assistant AvailableHi @celeztyne! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @celeztyne, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
Opened as draft waiting for KFLUXINFRA-2577 to be resolved |
Cluster was already deleted so we can proceed with this change now, the argoCD can be disconnected after |
|
@celeztyne Looks good but you missed a few places, probably they were added after initial commit. To find all the places, I did checkout this change locally and removed them all. So 2 options, I tell you all the places, you remove them and I verify again OR, I can just push the amendment to this PR, which one do you prefer? |
@hugares you can point me here what is missing and I'll include in a new commit, so I can see what I did miss |
Here are all the files that need to be modified or deleted: |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I have additionally removed
I hope is OK |
|
@celeztyne there is a merge conflict, please rebase this PR |
|
@celeztyne: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I have rebased but the PR still has the needs-rebase tag. If I can't fix this I guess I'm closing this one and open a new one |
|
New PR in #9521 |
As per KFLUXINFRA-2575 the pentest-p01 Cluster will be decommission as ProdSec has completed penetration testing. This specific change is to remove the cluster from infra-deployments overlay/Kustomize added in This commit (there were 71 fiels added, here is a file less - 70 - because a file has been deleted since - components/backup/production/pentest-p01/backup-tenants-schedule.yaml)