Skip to content

Conversation

@celeztyne
Copy link

@celeztyne celeztyne commented Dec 2, 2025

As per KFLUXINFRA-2575 the pentest-p01 Cluster will be decommission as ProdSec has completed penetration testing. This specific change is to remove the cluster from infra-deployments overlay/Kustomize added in This commit (there were 71 fiels added, here is a file less - 70 - because a file has been deleted since - components/backup/production/pentest-p01/backup-tenants-schedule.yaml)

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celeztyne
Once this PR has been reviewed and has the lgtm label, please assign skabashnyuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

🤖 Gemini AI Assistant Available

Hi @celeztyne! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

🤖 Hi @celeztyne, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@celeztyne
Copy link
Author

Opened as draft waiting for KFLUXINFRA-2577 to be resolved

@hugares
Copy link
Contributor

hugares commented Dec 2, 2025

Opened as draft waiting for KFLUXINFRA-2577 to be resolved

Cluster was already deleted so we can proceed with this change now, the argoCD can be disconnected after

@celeztyne celeztyne marked this pull request as ready for review December 2, 2025 16:29
@hugares
Copy link
Contributor

hugares commented Dec 2, 2025

@celeztyne Looks good but you missed a few places, probably they were added after initial commit.

To find all the places, I did checkout this change locally and removed them all. So 2 options, I tell you all the places, you remove them and I verify again OR, I can just push the amendment to this PR, which one do you prefer?

@celeztyne
Copy link
Author

@celeztyne Looks good but you missed a few places, probably they were added after initial commit.

To find all the places, I did checkout this change locally and removed them all. So 2 options, I tell you all the places, you remove them and I verify again OR, I can just push the amendment to this PR, which one do you prefer?

@hugares you can point me here what is missing and I'll include in a new commit, so I can see what I did miss

@hugares
Copy link
Contributor

hugares commented Dec 2, 2025

@celeztyne Looks good but you missed a few places, probably they were added after initial commit.
To find all the places, I did checkout this change locally and removed them all. So 2 options, I tell you all the places, you remove them and I verify again OR, I can just push the amendment to this PR, which one do you prefer?

@hugares you can point me here what is missing and I'll include in a new commit, so I can see what I did miss

Here are all the files that need to be modified or deleted:
modified: argo-cd-apps/base/member/infra-deployments/etcd-defrag/etcd-defrag.yaml
modified: argo-cd-apps/base/member/infra-deployments/kubearchive/kubearchive.yaml
modified: argo-cd-apps/base/member/infra-deployments/vector-kubearchive-log-collector/vector-kubearchive-log-collector.yaml
modified: argo-cd-apps/base/monitoring-blackbox/monitoring-blackbox.yaml
deleted: components/kubearchive/production/pentest-p01/kubearchive.yaml
deleted: components/kubearchive/production/pentest-p01/kustomization.yaml
modified: components/kubearchive/upgrade.sh
deleted: components/monitoring/blackbox/production/pentest-p01/kustomization.yaml
deleted: components/vector-kubearchive-log-collector/production/pentest-p01/kustomization.yaml
deleted: components/vector-kubearchive-log-collector/production/pentest-p01/loki-helm-generator.yaml
deleted: components/vector-kubearchive-log-collector/production/pentest-p01/loki-helm-prod-values.yaml
deleted: components/vector-kubearchive-log-collector/production/pentest-p01/loki-helm-values.yaml
deleted: components/vector-kubearchive-log-collector/production/pentest-p01/vector-helm-generator.yaml
deleted: components/vector-kubearchive-log-collector/production/pentest-p01/vector-helm-prod-values.yaml
deleted: components/vector-kubearchive-log-collector/production/pentest-p01/vector-helm-values.yaml

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@celeztyne
Copy link
Author

@celeztyne Looks good but you missed a few places, probably they were added after initial commit.
To find all the places, I did checkout this change locally and removed them all. So 2 options, I tell you all the places, you remove them and I verify again OR, I can just push the amendment to this PR, which one do you prefer?

@hugares you can point me here what is missing and I'll include in a new commit, so I can see what I did miss

Here are all the files that need to be modified or deleted: modified: argo-cd-apps/base/member/infra-deployments/etcd-defrag/etcd-defrag.yaml modified: argo-cd-apps/base/member/infra-deployments/kubearchive/kubearchive.yaml modified: argo-cd-apps/base/member/infra-deployments/vector-kubearchive-log-collector/vector-kubearchive-log-collector.yaml modified: argo-cd-apps/base/monitoring-blackbox/monitoring-blackbox.yaml deleted: components/kubearchive/production/pentest-p01/kubearchive.yaml deleted: components/kubearchive/production/pentest-p01/kustomization.yaml modified: components/kubearchive/upgrade.sh deleted: components/monitoring/blackbox/production/pentest-p01/kustomization.yaml deleted: components/vector-kubearchive-log-collector/production/pentest-p01/kustomization.yaml deleted: components/vector-kubearchive-log-collector/production/pentest-p01/loki-helm-generator.yaml deleted: components/vector-kubearchive-log-collector/production/pentest-p01/loki-helm-prod-values.yaml deleted: components/vector-kubearchive-log-collector/production/pentest-p01/loki-helm-values.yaml deleted: components/vector-kubearchive-log-collector/production/pentest-p01/vector-helm-generator.yaml deleted: components/vector-kubearchive-log-collector/production/pentest-p01/vector-helm-prod-values.yaml deleted: components/vector-kubearchive-log-collector/production/pentest-p01/vector-helm-values.yaml

I have additionally removed

  • configs/etcd-defrag/production/pentest-p01
  • configs/etcd-defrag/production/pentest-p01/kustomization.yaml

I hope is OK

@hugares
Copy link
Contributor

hugares commented Dec 4, 2025

@celeztyne there is a merge conflict, please rebase this PR

@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2025

@celeztyne: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests 7cb1b8a link true /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@celeztyne
Copy link
Author

I have rebased but the PR still has the needs-rebase tag. If I can't fix this I guess I'm closing this one and open a new one

@celeztyne
Copy link
Author

New PR in #9521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants