Skip to content

Conversation

@akira6592
Copy link
Contributor

What does this PR do?

fix default value for *_credentials_secure_logging in README.

How should this be tested?

N/A (Document only)

Is there a relevant Issue open for this?

resolves #990

Other Relevant info, PRs, etc

N/A (Document only)

@akira6592 akira6592 requested a review from a team as a code owner December 3, 2024 11:37
|Variable Name|Default Value|Required|Description|
|:---:|:---:|:---:|:---:|
|`controller_configuration_credentials_enforce_defaults`|`false`|no|Whether or not to enforce default option values on only the applications role|
|`controller_configuration_credentials_enforce_defaults`|`true`|no|Whether or not to enforce default option values on only the applications role|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you meant, controller_configuration_credentials_secure_logging not controller_configuration_credentials_enforce_defaults

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djdanielsson Thank you for review. I fixed it.

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson enabled auto-merge (squash) December 4, 2024 13:41
@djdanielsson djdanielsson merged commit 87e248c into redhat-cop:devel Dec 4, 2024
9 checks passed
@akira6592
Copy link
Contributor Author

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No consistency between README.md and defaults/main.yml in controller_credentials role

2 participants