Skip to content

fix default value for *_credentials_secure_logging in README #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djdanielsson merged 4 commits into from
Dec 4, 2024
Merged

fix default value for *_credentials_secure_logging in README #992

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df7b2a2
fix default value *_credentials_secure_logging in README
akira6592 Dec 3, 2024
4e0baca
manual revert controller_configuration_credentials_enforce_defaults d…
akira6592 Dec 4, 2024
74dd392
fix default value controller_configuration_credentials_secure_logging…
akira6592 Dec 4, 2024
d07e620
Merge branch 'devel' into fix-default-readme
djdanielsson Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/controller_credentials/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Enabling this will enforce configurtion without specifying every option in the c

|Variable Name|Default Value|Required|Description|
|:---:|:---:|:---:|:---:|
|`controller_configuration_credentials_enforce_defaults`|`false`|no|Whether or not to enforce default option values on only the applications role|
|`controller_configuration_credentials_enforce_defaults`|`true`|no|Whether or not to enforce default option values on only the applications role|
Copy link
Collaborator

@djdanielsson djdanielsson Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you meant, controller_configuration_credentials_secure_logging not controller_configuration_credentials_enforce_defaults

Copy link
Contributor Author

@akira6592 akira6592 Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djdanielsson Thank you for review. I fixed it.

|`aap_configuration_enforce_defaults`|`false`|no|This variable enables enforced default values as well, but is shared across multiple roles, see above.|

### Secure Logging Variables
Expand Down
2 changes: 1 addition & 1 deletion roles/eda_credentials/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ eda_configuration_credentials_secure_logging defaults to the value of aap_config

|Variable Name|Default Value|Required|Description|
|:---:|:---:|:---:|:---:|
|`eda_configuration_credentials_secure_logging`|`false`|no|Whether or not to include the sensitive Registry role tasks in the log. Set this value to `true` if you will be providing your sensitive values from elsewhere.|
|`eda_configuration_credentials_secure_logging`|`true`|no|Whether or not to include the sensitive Registry role tasks in the log. Set this value to `true` if you will be providing your sensitive values from elsewhere.|
|`aap_configuration_secure_logging`|`false`|no|Whether or not to include the sensitive Registry role tasks in the log. Set this value to `true` if you will be providing your sensitive values from elsewhere.|

### Asynchronous Retry Variables
Expand Down
Loading