Fixing more inconsistencies

roles/collect_async_status/README.md

@@ -35,7 +35,7 @@ This also speeds up the overall role.
 
 |Variable Name|Default Value|Required|Description|
 |:---:|:---:|:---:|:---:|
-|`aap_configuration_async_retries`|30|no|This variable sets the number of retries to attempt for the role globally.|
+|`aap_configuration_async_retries`|50|no|This variable sets the number of retries to attempt for the role globally.|
 |`cas_async_retries`|`{{ aap_configuration_async_retries }}`|no|This variable sets the number of retries to attempt for the role.|
 |`aap_configuration_async_delay`|1|no|This sets the delay between retries for the role globally.|
 |`cas_async_delay`|`aap_configuration_async_delay`|no|This sets the delay between retries for the role.|

roles/collect_async_status/defaults/main.yml

@@ -1,5 +1,5 @@
 ---
-cas_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
+cas_async_retries: "{{ aap_configuration_async_retries | default(50) }}"
 cas_async_delay: "{{ aap_configuration_async_delay | default(1) }}"
 cas_secure_logging: "{{ aap_configuration_secure_logging | default('false') }}"
 ...

roles/controller_ad_hoc_command/meta/argument_specs.yml

@@ -7,72 +7,72 @@ argument_specs:
         description: Data structure describing your ad hoc commands to run
         type: list
         elements: dict
-        # options:
-        #   job_type:
-        #     default: run
-        #     required: false
-        #     type: str
-        #     description: Job_type to use for the ad hoc command. Either run or check.
-        #   inventory:
-        #     required: true
-        #     type: str
-        #     description: Inventory to use for the ad hoc command.
-        #   limit:
-        #     required: false
-        #     type: str
-        #     description: Limit to use for the ad hoc command.
-        #   credential:
-        #     required: true
-        #     type: str
-        #     description: Credential to use for ad hoc command.
-        #   execution_environment:
-        #     required: false
-        #     type: str
-        #     description: Execution Environment to use for ad hoc command.
-        #   module_name:
-        #     required: true
-        #     type: str
-        #     description: The Ansible module to execute.
-        #   module_args:
-        #     required: false
-        #     type: str
-        #     description: The arguments to pass to the module.
-        #   forks:
-        #     default: 0
-        #     required: false
-        #     type: int
-        #     description: The number of forks to use for this ad hoc execution.
-        #   verbosity:
-        #     default: 0
-        #     required: false
-        #     type: int
-        #     description: Verbosity level for this ad hoc command run
-        #   extra_vars:
-        #     required: false
-        #     type: dict
-        #     description: Extra variables to use for the ad hoc command.
-        #   become_enabled:
-        #     required: false
-        #     type: bool
-        #     description: If the become flag should be set.
-        #   diff_mode:
-        #     required: false
-        #     type: bool
-        #     description: Show the changes made by Ansible tasks where supported
-        #   wait:
-        #     default: false
-        #     required: false
-        #     type: bool
-        #     description: Wait for the command to complete.
-        #   interval:
-        #     default: 2
-        #     required: false
-        #     type: int
-        #     description: The interval to request an update from controller.
-        #   timeout:
-        #     required: false
-        #     type: int
-        #     description: If waiting for the command to complete this will abort after this amount of seconds.
+        options:
+          job_type:
+            default: run
+            required: false
+            type: str
+            description: Job_type to use for the ad hoc command. Either run or check.
+          inventory:
+            required: true
+            type: str
+            description: Inventory to use for the ad hoc command.
+          limit:
+            required: false
+            type: str
+            description: Limit to use for the ad hoc command.
+          credential:
+            required: true
+            type: str
+            description: Credential to use for ad hoc command.
+          execution_environment:
+            required: false
+            type: str
+            description: Execution Environment to use for ad hoc command.
+          module_name:
+            required: true
+            type: str
+            description: The Ansible module to execute.
+          module_args:
+            required: false
+            type: str
+            description: The arguments to pass to the module.
+          forks:
+            default: 0
+            required: false
+            type: int
+            description: The number of forks to use for this ad hoc execution.
+          verbosity:
+            default: 0
+            required: false
+            type: int
+            description: Verbosity level for this ad hoc command run
+          extra_vars:
+            required: false
+            type: dict
+            description: Extra variables to use for the ad hoc command.
+          become_enabled:
+            required: false
+            type: bool
+            description: If the become flag should be set.
+          diff_mode:
+            required: false
+            type: bool
+            description: Show the changes made by Ansible tasks where supported
+          wait:
+            default: false
+            required: false
+            type: bool
+            description: Wait for the command to complete.
+          interval:
+            default: 2
+            required: false
+            type: int
+            description: The interval to request an update from controller.
+          timeout:
+            required: false
+            type: int
+            description: If waiting for the command to complete this will abort after this amount of seconds.
 
       # No_log variables
       controller_configuration_ad_hoc_command_secure_logging:

roles/controller_ad_hoc_command_cancel/meta/argument_specs.yml

@@ -7,26 +7,26 @@ argument_specs:
         description: Data structure describing your ad hoc jobs to cancel
         type: list
         elements: dict
-        # options:
-        #   id:
-        #     required: true
-        #     type: int
-        #     description: ID of the command to cancel
-        #   fail_if_not_running:
-        #     default: false
-        #     required: false
-        #     type: bool
-        #     description: Fail loudly if the command can not be canceled.
-        #   interval:
-        #     default: 0
-        #     required: false
-        #     type: int
-        #     description: The interval in seconds, to request an update from.
-        #   timeout:
-        #     default: 0
-        #     required: false
-        #     type: int
-        #     description: Maximum time in seconds to wait for a job to finish, 0 means wait until it is finished regardless.
+        options:
+          id:
+            required: true
+            type: int
+            description: ID of the command to cancel
+          fail_if_not_running:
+            default: false
+            required: false
+            type: bool
+            description: Fail loudly if the command can not be canceled.
+          interval:
+            default: 0
+            required: false
+            type: int
+            description: The interval in seconds, to request an update from.
+          timeout:
+            default: 0
+            required: false
+            type: int
+            description: Maximum time in seconds to wait for a job to finish, 0 means wait until it is finished regardless.
 
       # No_log variables
       controller_configuration_ad_hoc_command_cancel_secure_logging:

roles/controller_applications/README.md

@@ -59,7 +59,7 @@ This also speeds up the overall role.
 
 |Variable Name|Default Value|Required|Description|
 |:---:|:---:|:---:|:---:|
-|`aap_configuration_async_retries`|30|no|This variable sets the number of retries to attempt for the role globally.|
+|`aap_configuration_async_retries`|50|no|This variable sets the number of retries to attempt for the role globally.|
 |`controller_configuration_applications_async_retries`|`{{ aap_configuration_async_retries }}`|no|This variable sets the number of retries to attempt for the role.|
 |`aap_configuration_async_delay`|1|no|This sets the delay between retries for the role globally.|
 |`controller_configuration_applications_async_delay`|`aap_configuration_async_delay`|no|This sets the delay between retries for the role.|

roles/controller_applications/defaults/main.yml

@@ -2,7 +2,7 @@
 # a list of dictionaries describing the Controller applications
 aap_applications: []
 controller_configuration_applications_secure_logging: "{{ aap_configuration_secure_logging | default('false') }}"
-controller_configuration_applications_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
+controller_configuration_applications_async_retries: "{{ aap_configuration_async_retries | default(50) }}"
 controller_configuration_applications_async_delay: "{{ aap_configuration_async_delay | default(1) }}"
 controller_configuration_applications_loop_delay: "{{ aap_configuration_loop_delay | default(0) }}"
 aap_configuration_async_dir:

roles/controller_applications/meta/argument_specs.yml

@@ -7,51 +7,51 @@ argument_specs:
         description: Data structure describing your applications
         type: list
         elements: dict
-        # options:
-        #   name:
-        #     required: true
-        #     type: str
-        #     description: Name of application
-        #   organization:
-        #     required: true
-        #     type: str
-        #     description: Name of the organization for the application
-        #   description:
-        #     required: false
-        #     type: str
-        #     description: Description to use for the application.
-        #   authorization_grant_type:
-        #     default: password
-        #     required: false
-        #     type: str
-        #     description: Grant type for tokens in this application, "password" or "authorization-code"
-        #   client_type:
-        #     default: public
-        #     required: false
-        #     type: str
-        #     description: Application client type, "confidential" or "public"
-        #   redirect_uris:
-        #     required: false
-        #     type: str
-        #     description: Allowed urls list, space separated. Required with "authorization-code" grant type
-        #   skip_authorization:
-        #     default: false
-        #     required: false
-        #     type: bool
-        #     description: Set true to skip authorization step for completely trusted applications.
-        #   state:
-        #     default: "{{ controller_state | default('present') }}"
-        #     required: false
-        #     type: str
-        #     description: Desired state of the application.
+        options:
+          name:
+            required: true
+            type: str
+            description: Name of application
+          organization:
+            required: true
+            type: str
+            description: Name of the organization for the application
+          description:
+            required: false
+            type: str
+            description: Description to use for the application.
+          authorization_grant_type:
+            default: password
+            required: false
+            type: str
+            description: Grant type for tokens in this application, "password" or "authorization-code"
+          client_type:
+            default: public
+            required: false
+            type: str
+            description: Application client type, "confidential" or "public"
+          redirect_uris:
+            required: false
+            type: str
+            description: Allowed urls list, space separated. Required with "authorization-code" grant type
+          skip_authorization:
+            default: false
+            required: false
+            type: bool
+            description: Set true to skip authorization step for completely trusted applications.
+          state:
+            default: "{{ controller_state | default('present') }}"
+            required: false
+            type: str
+            description: Desired state of the application.
 
       # Async variables
       controller_configuration_applications_async_retries:
-        default: "{{ aap_configuration_async_retries | default(30) }}"
+        default: "{{ aap_configuration_async_retries | default(50) }}"
         required: false
         description: This variable sets the number of retries to attempt for the role.
       aap_configuration_async_retries:
-        default: 30
+        default: 50
         required: false
         description: This variable sets number of retries across all roles as a default.
       controller_configuration_applications_async_delay:
@@ -63,9 +63,25 @@ argument_specs:
         required: false
         description: This variable sets delay between retries across all roles as a default.
       aap_configuration_async_dir:
-        default:
+        default: null
         required: false
         description: Sets the directory to write the results file for async tasks. The default value is set to `null` which uses the Ansible Default of `/root/.ansible_async/`.
+      controller_configuration_applications_loop_delay:
+        default: "{{ aap_configuration_loop_delay | default(0) }}"
+        required: false
+        description: This variable sets the pause between each item in the loop for the role.
+      aap_configuration_loop_delay:
+        default: 0
+        required: false
+        description: This variable sets the pause between each item in the loop for the roles globally.
+      controller_configuration_applications_enforce_defaults:
+        default: "{{ aap_configuration_enforce_defaults | default(false) }}"
+        required: false
+        description: This variable enforces default values for optional fields.
+      aap_configuration_enforce_defaults:
+        default: false
+        required: false
+        description: This variable enforces default values for optional fields across all roles.
 
       # No_log variables
       controller_configuration_applications_secure_logging:

roles/controller_bulk_host_create/README.md

@@ -42,7 +42,7 @@ This also speeds up the overall role.
 
 |Variable Name|Default Value|Required|Description|
 |:---:|:---:|:---:|:---:|
-|`aap_configuration_async_retries`|30|no|This variable sets the number of retries to attempt for the role globally.|
+|`aap_configuration_async_retries`|50|no|This variable sets the number of retries to attempt for the role globally.|
 |`controller_configuration_bulk_hosts_async_retries`|`{{ aap_configuration_async_retries }}`|no|This variable sets the number of retries to attempt for the role.|
 |`aap_configuration_async_delay`|1|no|This sets the delay between retries for the role globally.|
 |`controller_configuration_bulk_hosts_async_delay`|`aap_configuration_async_delay`|no|This sets the delay between retries for the role.|

roles/controller_bulk_host_create/defaults/main.yml

@@ -1,6 +1,6 @@
 ---
 controller_configuration_bulk_hosts_secure_logging: "{{ aap_configuration_secure_logging | default('false') }}"
-controller_configuration_bulk_hosts_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
+controller_configuration_bulk_hosts_async_retries: "{{ aap_configuration_async_retries | default(50) }}"
 controller_configuration_bulk_hosts_async_delay: "{{ aap_configuration_async_delay | default(1) }}"
 controller_configuration_bulk_hosts_loop_delay: "{{ aap_configuration_loop_delay | default(0) }}"
 aap_configuration_async_dir:

roles/controller_bulk_host_create/meta/argument_specs.yml

@@ -10,7 +10,7 @@ argument_specs:
 
       # Async variables
       aap_configuration_async_dir:
-        default:
+        default: null
         required: false
         description: Sets the directory to write the results file for async tasks. The default value is set to `null` which uses the Ansible Default of `/root/.ansible_async/`.
 

roles/controller_bulk_job_launch/README.md

@@ -42,7 +42,7 @@ This also speeds up the overall role.
 
 |Variable Name|Default Value|Required|Description|
 |:---:|:---:|:---:|:---:|
-|`aap_configuration_async_retries`|30|no|This variable sets the number of retries to attempt for the role globally.|
+|`aap_configuration_async_retries`|50|no|This variable sets the number of retries to attempt for the role globally.|
 |`controller_configuration_bulk_job_launch_async_retries`|`{{ aap_configuration_async_retries }}`|no|This variable sets the number of retries to attempt for the role.|
 |`aap_configuration_async_delay`|1|no|This sets the delay between retries for the role globally.|
 |`controller_configuration_bulk_job_launch_async_delay`|`aap_configuration_async_delay`|no|This sets the delay between retries for the role.|

roles/controller_bulk_job_launch/defaults/main.yml

@@ -1,6 +1,6 @@
 ---
 controller_configuration_bulk_job_launch_secure_logging: "{{ aap_configuration_secure_logging | default('false') }}"
-controller_configuration_bulk_job_launch_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
+controller_configuration_bulk_job_launch_async_retries: "{{ aap_configuration_async_retries | default(50) }}"
 controller_configuration_bulk_job_launch_async_delay: "{{ aap_configuration_async_delay | default(1) }}"
 controller_configuration_bulk_job_launch_loop_delay: "{{ aap_configuration_loop_delay | default(0) }}"
 ...

roles/controller_credential_input_sources/README.md

@@ -59,7 +59,7 @@ This also speeds up the overall role.
 
 |Variable Name|Default Value|Required|Description|
 |:---:|:---:|:---:|:---:|
-|`aap_configuration_async_retries`|30|no|This variable sets the number of retries to attempt for the role globally.|
+|`aap_configuration_async_retries`|50|no|This variable sets the number of retries to attempt for the role globally.|
 |`controller_configuration_credential_input_sources_async_retries`|`{{ aap_configuration_async_retries }}`|no|This variable sets the number of retries to attempt for the role.|
 |`aap_configuration_async_delay`|1|no|This sets the delay between retries for the role globally.|
 |`controller_configuration_credential_input_sources_async_delay`|`aap_configuration_async_delay`|no|This sets the delay between retries for the role.|

roles/controller_credential_input_sources/defaults/main.yml

@@ -2,7 +2,7 @@
 # list of dicts describing Controller credential input sources
 controller_credential_input_sources: []
 controller_configuration_credential_input_sources_secure_logging: "{{ aap_configuration_secure_logging | default('false') }}"
-controller_configuration_credential_input_sources_async_retries: "{{ aap_configuration_async_retries | default(30) }}"
+controller_configuration_credential_input_sources_async_retries: "{{ aap_configuration_async_retries | default(50) }}"
 controller_configuration_credential_input_sources_async_delay: "{{ aap_configuration_async_delay | default(1) }}"
 controller_configuration_credential_input_sources_loop_delay: "{{ aap_configuration_loop_delay | default(0) }}"
 aap_configuration_async_dir: