BACKPORT: Add missing request_timeout option to credential role #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Obviously a lot of the CI will now fail... |
Collaborator
Author
|
Backports happen in their own repo now. PR raised: redhat-cop/infra.controller_configuration#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds previously fixed missing
request_timeoutoption to the credentials roleHow should this be tested?
The option is available
Is there a relevant Issue open for this?
resolves #936
Other Relevant info, PRs, etc
This is PR is against the new
controller_configurationbranch which will exist for backports like this. Releases can be done from this branch. In likelihood these will mostly be bug fixes like this and will be released as2.11.z