Skip to content

RI-6927: Rename some provider and telemetry event names #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −11
Open

RI-6927: Rename some provider and telemetry event names #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94f477b
remove the autodiscovery telemetry events as they are not used
dantovska Aug 15, 2025
c75e4ca
update the provider names
dantovska Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/webviews/src/constants/connections/databases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export enum ConnectionType {
export enum ConnectionProvider {
UNKNOWN = 'UNKNOWN',
LOCALHOST = 'LOCALHOST',
RE_CLUSTER = 'RE_CLUSTER',
RE_CLOUD = 'RE_CLOUD',
REDIS_SOFTWARE = 'REDIS_SOFTWARE',
REDIS_CLOUD = 'REDIS_CLOUD',
AZURE = 'AZURE',
AWS = 'AWS',
GOOGLE = 'GOOGLE',
Expand Down
4 changes: 2 additions & 2 deletions src/webviews/src/interfaces/database/databases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ export enum ConnectionType {
export enum ConnectionProvider {
UNKNOWN = 'UNKNOWN',
LOCALHOST = 'LOCALHOST',
RE_CLUSTER = 'RE_CLUSTER',
RE_CLOUD = 'RE_CLOUD',
REDIS_SOFTWARE = 'REDIS_SOFTWARE',
REDIS_CLOUD = 'REDIS_CLOUD',
AZURE = 'AZURE',
AWS = 'AWS',
GOOGLE = 'GOOGLE',
Expand Down
2 changes: 1 addition & 1 deletion src/webviews/src/modules/add-key/components/AddKeyReJSON/AddKeyReJSON.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const mockConnectedDatabase: Nullable<Database> = {
tls: false,
db: 0,
lastConnection: new Date(),
provider: 'RE_CLOUD',
provider: 'REDIS_CLOUD',
connectionType: ConnectionType.Standalone,
version: null,
}
Expand Down
6 changes: 0 additions & 6 deletions src/webviews/src/utils/telemetry/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ export enum TelemetryEvent {
CONFIG_DATABASES_OPEN_DATABASE = 'CONFIG_DATABASES_OPEN_DATABASE',
CONFIG_DATABASES_CLICKED = 'CONFIG_DATABASES_CLICKED',
CONFIG_DATABASES_MANUALLY_SUBMITTED = 'CONFIG_DATABASES_MANUALLY_SUBMITTED',
CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_SUBMITTED = 'CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_SUBMITTED',
CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_CANCELLED = 'CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_CANCELLED',
CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBMITTED = 'CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBMITTED',
CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_CANCELLED = 'CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_CANCELLED',
CONFIG_DATABASES_REDIS_SENTINEL_AUTODISCOVERY_SUBMITTED = 'CONFIG_DATABASES_REDIS_SENTINEL_AUTODISCOVERY_SUBMITTED',
CONFIG_DATABASES_REDIS_SENTINEL_AUTODISCOVERY_CANCELLED = 'CONFIG_DATABASES_REDIS_SENTINEL_AUTODISCOVERY_CANCELLED',
Comment on lines -22 to -27
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are unused events, right?

Copy link
Collaborator Author

@dantovska dantovska Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

CONFIG_DATABASES_GET_REDIS_CLOUD_ACCOUNT_CLICKED = 'CONFIG_DATABASES_GET_REDIS_CLOUD_ACCOUNT_CLICKED',
CREATE_FREE_CLOUD_DATABASE_CLICKED = 'CREATE_FREE_CLOUD_DATABASE_CLICKED',
CONFIG_DATABASES_DATABASE_CLONE_REQUESTED = 'CONFIG_DATABASES_DATABASE_CLONE_REQUESTED',
Expand Down