-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for XREADGROUP CLAIM arg #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
afc4947
84438de
2e04494
085d857
79c7439
da3ebcb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -23,6 +23,8 @@ public class XReadArgs implements CompositeArgument { | |||||||||||||||||||
|
|
||||||||||||||||||||
| private boolean noack; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| private Long claimMinIdleTime; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| /** | ||||||||||||||||||||
| * Builder entry points for {@link XReadArgs}. | ||||||||||||||||||||
| */ | ||||||||||||||||||||
|
|
@@ -90,6 +92,21 @@ public static XReadArgs noack(boolean noack) { | |||||||||||||||||||
| return new XReadArgs().noack(noack); | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| /** | ||||||||||||||||||||
| * Create a new {@link XReadArgs} and set CLAIM min-idle-time (milliseconds). Only valid for XREADGROUP. | ||||||||||||||||||||
| */ | ||||||||||||||||||||
| public static XReadArgs claim(long milliseconds) { | ||||||||||||||||||||
| return new XReadArgs().claim(milliseconds); | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| /** | ||||||||||||||||||||
| * Create a new {@link XReadArgs} and set CLAIM min-idle-time. Only valid for XREADGROUP. | ||||||||||||||||||||
| */ | ||||||||||||||||||||
|
||||||||||||||||||||
| */ | |
| */ | |
| /** | |
| * Create a new {@link XReadArgs} and set CLAIM min-idle-time. Only valid for XREADGROUP. | |
| * | |
| * @param timeout the minimum idle time as a {@link Duration} | |
| * @return new {@link XReadArgs} with CLAIM set | |
| * @see XReadArgs#claim(Duration) | |
| */ |
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing JavaDoc parameters and return value documentation. The method should document:
@param millisecondsthe minimum idle time in milliseconds@return{@code this} XReadArgs instance for method chaining
| * | |
| * | |
| * @param milliseconds the minimum idle time in milliseconds | |
| * @return {@code this} XReadArgs instance for method chaining |
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing JavaDoc parameters and return value documentation. The method should document:
@param timeoutthe minimum idle time as a Duration@return{@code this} XReadArgs instance for method chaining
| * | |
| * | |
| * @param timeout the minimum idle time as a Duration | |
| * @return {@code this} XReadArgs instance for method chaining |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing JavaDoc parameters and return value documentation. The method should document:
@param millisecondsthe minimum idle time in milliseconds@returnnew {@link XReadArgs} with CLAIM set@see XReadArgs#claim(long)for consistency with other Builder methods