Add TTBR values to TLB results #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febyeji
force-pushed
the
optimization/promise-first
branch
from
9f1f977 to
b898dc2
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
3 times, most recently
from
0232e0f to
ea71c6d
Compare
febyeji
force-pushed
the
optimization/promise-first
branch
from
1e9a319 to
7f3f7f9
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
ea71c6d to
c59893f
Compare
febyeji
force-pushed
the
optimization/promise-first
branch
2 times, most recently
from
4af0adb to
984fc1b
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
c59893f to
49a85b0
Compare
febyeji
force-pushed
the
optimization/promise-first
branch
from
984fc1b to
d1798c9
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
49a85b0 to
f78affb
Compare
febyeji
force-pushed
the
optimization/promise-first
branch
from
ed82e3e to
962f50e
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
f78affb to
c4ed3ec
Compare
tperami
reviewed
Nov 14, 2025
Collaborator
tperami
left a comment
tperami
left a comment
There was a problem hiding this comment.
We need to review some semantics about the register lists and the trs lifetime, but apart from that this is very good, thanks!
febyeji
force-pushed
the
optimization/promise-first
branch
2 times, most recently
from
769b651 to
80b7aad
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
a8da16f to
5049e6f
Compare
febyeji
force-pushed
the
optimization/promise-first
branch
from
533182a to
53d1c39
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
5049e6f to
9e628cc
Compare
tperami
approved these changes
Nov 24, 2025
Collaborator
tperami
left a comment
tperami
left a comment
There was a problem hiding this comment.
This is good to go when the comments are addressed, but I'll wait until 2 Dec to merge. Also, the commit message should mention that is not only adding TTBR in TLB support but also fixing support for upper/lower range stuff.
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
9e628cc to
b0a7879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_reg_readnow branches when the implicit register reads occur during the translation. The base address of the page table walk in the ISA is read from the TLB in the memory model.Entry.is_upperto calculateprefix_to_va