Implement break-before-make check #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febyeji
force-pushed
the
feature/bbm-checker
branch
from
e3540a9 to
fb9172a
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
a8da16f to
5049e6f
Compare
febyeji
force-pushed
the
feature/bbm-checker
branch
from
fb9172a to
b3c82e2
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
5049e6f to
9e628cc
Compare
febyeji
force-pushed
the
feature/bbm-checker
branch
from
b3c82e2 to
8be7f30
Compare
febyeji
force-pushed
the
feature/tlb-ttbr
branch
from
9e628cc to
b0a7879
Compare
febyeji
force-pushed
the
feature/bbm-checker
branch
from
8be7f30 to
95802b4
Compare
tperami
reviewed
Nov 26, 2025
Collaborator
tperami
left a comment
tperami
left a comment
There was a problem hiding this comment.
Sorry not a full review but here are the comment I wrote during the last meeting
| omap (λ fe, | ||
| if decide (FE.lvl fe = plvl) | ||
| then Some (FE.ctxt fe) | ||
| else None) (elements tlb.(vatlb)) in |
Collaborator
There was a problem hiding this comment.
Don't filter just context, directly enumerate full entries, and make traverse_lvl take a full entry directly
| $ regval_to_val ttbr sreg.1; | ||
| let entry_addr := next_entry_addr val_ttbr va in | ||
| let loc := Loc.from_addr_in entry_addr in | ||
| if (Memory.read_at loc init mem time) is Some (memval, _) then |
Collaborator
There was a problem hiding this comment.
The memory not being found should be a catch fire condition
| (mem : Memory.t) | ||
| (time : nat) | ||
| (lvl : Level) | ||
| (ttbr : reg) : result string (t * bool) := |
Collaborator
There was a problem hiding this comment.
Take a parameter asids : gset (bv 16) and only push entries at those asids
| | Some plvl => | ||
| let pctxts := remove_dups $ | ||
| omap (λ fe, | ||
| if decide (FE.lvl fe = plvl) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.