Lean: compat between early return and exception #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Early returns are encoded using an exception monad in Lean, and it did not allow to throw exceptions. As a by-product, we move some definitions from `Specialization.lean` to `Sail.lean`.
Test Results 16 files 36 suites 0s ⏱️ Results for commit 536972c. |
Contributor
|
Is there a test for this? Perhaps one of the skipped C-suite tests should start working? |
Collaborator
Author
|
@bacam I added a test in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early returns are encoded using an exception monad in Lean, and it did not allow to throw exceptions. As a by-product, we move some definitions from
Specialization.leantoSail.lean.