-
Notifications
You must be signed in to change notification settings - Fork 1
Setup dotenv #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Setup dotenv #420
Conversation
| where the `project-name` is exactly the one you chose before. | ||
|
|
||
| > ⚠️ You may want to choose a different database than Postgres, but most of the time this will be your choice.\ | ||
| > If you do not need a DB you may rethink the fact that you may not need Rails at all: Take a look at [Sinatra](http://www.sinatrarb.com/) or [Angular](https://angular.io/)\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a shitty suggestion. It is not the fact that you have a database or not that should make consider alternative frameworks.
| * Run `bin/setup` | ||
|
|
||
| * Run `bundle exec rails db:migrate` to generate an empty `schema.rb` file. | ||
| * Run `bin/setup` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we first need to run db:migrate
| * Run `bin/setup` | ||
|
|
||
| * Then check your default Rails setup by running `rails s` and visiting http://localhost:3000. | ||
| * Then check your default Rails setup by running `bin/run` and visiting http://[project-name].localhost:3000. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's check bin/run and subdomain and start from the beginning with a good habit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add all the commands to the bin/setup?
I think now if you create a new Rails application and run bin/setup, you end up with the app running on localhost.
1d0a1db to
8360c61
Compare
8360c61 to
065fc90
Compare
| > Have you decided if you need two environments (develop and main) or just one? | ||
| > As a rule of thumb: for customers we always use two environments, for internal projects we usually only use one. | ||
| > Why the difference? Because we can bare the risk of having a bug in an internal project, but we cannot do that for a customer. | ||
| > Decide with your team if you want one or two branches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could be more explicit with this line that the customer opinion / need is not to be disregarded? I know it's implied from the whole paragraph, but I guess it could be interpreted as such
Setting up a new project, I don't really want to setup dotenv manually.
Here I am automating its installation but also introducing a new opt-out feature.
I'd like to be able to opt-out also from other things, like renuocop or renuo-cli, but I'll do that in a separate PR.
cc @CuddlyBunion341