You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@reown/appkit - Main Entry
Size limit: 80 kB
Size: 71.1 kB with all dependencies, minified and gzipped
Loading time: 1.4 s on slow 3G
Running time: 476 ms on Snapdragon 410
Total time: 1.9 s
@reown/appkit/react
Size limit: 230 kB
Size: 228.25 kB with all dependencies, minified and gzipped
Loading time: 4.5 s on slow 3G
Running time: 905 ms on Snapdragon 410
Total time: 5.4 s
@reown/appkit/vue
Size limit: 80 kB
Size: 71.1 kB with all dependencies, minified and gzipped
Loading time: 1.4 s on slow 3G
Running time: 495 ms on Snapdragon 410
Total time: 1.9 s
@reown/appkit-scaffold-ui
Size limit: 220 kB
Size: 209.42 kB with all dependencies, minified and gzipped
Loading time: 4.1 s on slow 3G
Running time: 586 ms on Snapdragon 410
Total time: 4.7 s
@reown/appkit-ui
Size limit: 500 kB
Size: 13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms on slow 3G
Running time: 47 ms on Snapdragon 410
Total time: 304 ms
Great work on implementing CAIP-2 format for the new network image IDs! I've been testing multi-chain integrations with Tron, Stacks, and Near in my Base dApp implementations, and this standardization will significantly improve wallet connectivity consistency across these networks.
The NetworkImageIds migration to CAIP-2 format is particularly valuable for developers building cross-chain applications. In my experience with AppKit integration on Base mainnet, having consistent network identifiers reduces connection errors and improves user experience when switching between different blockchain networks.
Have you considered adding visual regression tests specifically for these new network icons to ensure they render correctly across different wallet interfaces? This would be especially important for Tron and Near which have distinctive branding requirements.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new images ids for Tron, Stacks, Near
NetworkImageIdswould have to be changed to CAIP-2 format instead of just chain IDType of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist