-
Notifications
You must be signed in to change notification settings - Fork 872
feat(preview-server): error feedback for rate limiting #1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gabrielmfern
merged 3 commits into
canary
from
feat/error-feedback-for-test-email-sending
Dec 10, 2025
Merged
feat(preview-server): error feedback for rate limiting #1735
gabrielmfern
merged 3 commits into
canary
from
feat/error-feedback-for-test-email-sending
Dec 10, 2025
+55
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 89d577f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ecdf85c to
971aa33
Compare
66c5ab9 to
9f5b6d3
Compare
971aa33 to
778a6bb
Compare
4ee4d1d to
0187b0a
Compare
bf3f899 to
1748335
Compare
addf436 to
ade5f69
Compare
3ff8597 to
3c4ea0a
Compare
7da803f to
e9af285
Compare
778a6bb to
925e049
Compare
353784c to
aa45ff7
Compare
commit: |
isabellaaquino
approved these changes
Dec 9, 2025
gabrielmfern
added a commit
that referenced
this pull request
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the response from fetch was, for some reason, throwing an error and falling back to the generic error message when there was a rate limiting. I'm not sure what causes it, but moving the fetch to a server action fixes this temporarily.
To illustrate, if the code is changed to
The error message when trying to send more emails than the rate limiting window we have set up allows becomes:
And the exception in the console looks like: