fix(react-email): nodejs 25 warning about argument concatenation #2642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to use Node.js 25 and I've noticed that every time I used the
email-devscript, there was a warning:This is referring to:
react-email/packages/react-email/dev/index.js
Lines 12 to 16 in 30724df
Which is using
shell: truehere, and which causes the warning. In this specific use case, we can simply removeshell: truesince we're using the direct path to the binary and aren't using any shell specific features.Summary by cubic
Removed shell: true from the react-email dev script to stop the Node.js 25 DEP0190 warning and avoid unsafe argument concatenation. We now spawn tsx directly via its path; no shell features are needed.
Written for commit 5cbab69. Summary will update automatically on new commits.