Skip to content

Conversation

@royendo
Copy link
Contributor

@royendo royendo commented Nov 25, 2025

Second iteration from #8364
due to lots of new changes in main :)

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@royendo
Copy link
Contributor Author

royendo commented Nov 25, 2025

adding back skip for credentials based connectors, until we have connector detection baked in :)

@royendo royendo marked this pull request as ready for review November 25, 2025 20:09
@royendo royendo requested a review from lovincyrus November 25, 2025 20:09
@royendo royendo marked this pull request as draft December 1, 2025 14:24
@royendo royendo changed the title adding public option and changing button behavior based on selection. adding public option, remove skip, and help text changes Dec 5, 2025
@royendo royendo marked this pull request as ready for review December 5, 2025 21:11
@lovincyrus
Copy link
Contributor

lovincyrus commented Dec 9, 2025

Added the fixes to #8467 @royendo

@royendo royendo closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants